mirror of
https://github.com/siderolabs/talos.git
synced 2025-10-10 07:01:12 +02:00
bec89bf6e5
The problem showed up on 'reset' of the Talos node which had multiple endpoints for other control plane nodes, many of which weren't actually available. When 'grpc.WithBlock()' is used, etcd will try to dial the first endpoint and return an error if the dial fails. Use noblock mode by default with multiple endpoints, and blocking mode with a single endpoint. Pass the context to etcd to properly abort dial operations if the context get canceled. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
45 lines
1.2 KiB
Go
45 lines
1.2 KiB
Go
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
package etcd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"go.etcd.io/etcd/client/v3/concurrency"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
// WithLock executes the given function exclusively by acquiring an Etcd lock with the given key.
|
|
func WithLock(ctx context.Context, key string, logger *zap.Logger, f func() error) error {
|
|
etcdClient, err := NewLocalClient(ctx)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating etcd client: %w", err)
|
|
}
|
|
|
|
defer etcdClient.Close() //nolint:errcheck
|
|
|
|
session, err := concurrency.NewSession(etcdClient.Client)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating etcd session: %w", err)
|
|
}
|
|
|
|
defer session.Close() //nolint:errcheck
|
|
|
|
mutex := concurrency.NewMutex(session, key)
|
|
|
|
logger.Debug("waiting for mutex", zap.String("key", key))
|
|
|
|
if err = mutex.Lock(ctx); err != nil {
|
|
return fmt.Errorf("error acquiring mutex for key %s: %w", key, err)
|
|
}
|
|
|
|
logger.Debug("mutex acquired", zap.String("key", key))
|
|
|
|
defer mutex.Unlock(ctx) //nolint:errcheck
|
|
|
|
return f()
|
|
}
|