mirrors/talos
1
0
Fork 0
mirror of https://github.com/siderolabs/talos.git synced 2025-10-18 11:01:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: tweak nolintlint settings

Browse Source 
Copy from kres manually for now.

Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
This commit is contained in:
Alexey Palazhchenko 2021-03-25 23:23:42 +03:00 committed by talos-bot
parent 1f5a0c4065
commit fb605a0fc5
4 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.golangci.yml
View File

@ -99,6 +99,12 @@ linters-settings:
nakedret: nakedret:
# make an issue if func has more lines of code than this setting and it has naked returns; default is 30 # make an issue if func has more lines of code than this setting and it has naked returns; default is 30
max-func-lines: 30 max-func-lines: 30
nolintlint:
allow-unused: false
allow-leading-space: false
allow-no-explanation: []
require-explanation: false
require-specific: true
prealloc: prealloc:
# XXX: we don't recommend using this linter before doing performance profiling. # XXX: we don't recommend using this linter before doing performance profiling.
# For most programs usage of prealloc will be a premature optimization. # For most programs usage of prealloc will be a premature optimization.

2
cmd/talosctl/cmd/talos/convert-k8s.go
View File

@ -36,7 +36,7 @@ func init() {
convertK8sCmd.Flags().BoolVar(&convertOptions.OnlyRemoveInitializedKey, "remove-initialized-key", false, "only remove bootkube initialized key (used in manual conversion)") convertK8sCmd.Flags().BoolVar(&convertOptions.OnlyRemoveInitializedKey, "remove-initialized-key", false, "only remove bootkube initialized key (used in manual conversion)")
// hiding this flag as it should only be used in manual process (and it's documented there), but should never be used in automatic conversion // hiding this flag as it should only be used in manual process (and it's documented there), but should never be used in automatic conversion
convertK8sCmd.Flags().MarkHidden("remove-initialized-key") //nolint: errcheck convertK8sCmd.Flags().MarkHidden("remove-initialized-key") //nolint:errcheck
addCommand(convertK8sCmd) addCommand(convertK8sCmd)
} }

2
internal/app/networkd/pkg/server/server.go
View File

@ -36,7 +36,7 @@ func (r *NetworkServer) Routes(ctx context.Context, in *empty.Empty) (reply *net
return nil, err return nil, err
} }
defer conn.Close() //nolint: errcheck defer conn.Close() //nolint:errcheck
list, err := conn.Route.List() list, err := conn.Route.List()
if err != nil { if err != nil {

4
pkg/cluster/kubernetes/talos_managed.go
View File

@ -167,8 +167,8 @@ func upgradeConfigPatcher(options UpgradeOptions, service string, configResource
config.ClusterConfig = &v1alpha1config.ClusterConfig{} config.ClusterConfig = &v1alpha1config.ClusterConfig{}
} }
configData := configResource.(*resource.Any).Value().(map[string]interface{}) //nolint: errcheck,forcetypeassert configData := configResource.(*resource.Any).Value().(map[string]interface{}) //nolint:errcheck,forcetypeassert
configImage := configData["image"].(string) //nolint: errcheck,forcetypeassert configImage := configData["image"].(string) //nolint:errcheck,forcetypeassert
switch service { switch service {
case kubeAPIServer: case kubeAPIServer: