From e5cabd42cc7f86bee5486f73fa4068382bf6a7fb Mon Sep 17 00:00:00 2001 From: Andrey Smirnov Date: Thu, 15 Sep 2022 18:06:06 +0400 Subject: [PATCH] feat: enable etcd consistency hashcheck This will be only enabled for Talos v1.3.x. Signed-off-by: Andrey Smirnov --- hack/release.toml | 9 +++++++++ internal/app/machined/pkg/system/services/etcd.go | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hack/release.toml b/hack/release.toml index ed553cda2..1cd8776e6 100644 --- a/hack/release.toml +++ b/hack/release.toml @@ -45,6 +45,15 @@ Talos now supports the Nano Pi R4S SBC. * CoreDNS: v1.9.4 * etcd: v3.5.5 * Linux: 5.15.68 +""" + + [notes.etcd] + title = "etcd Consistency Check" + description="""\ +Talos enables [--experimental-compact-hash-check-enabled](https://github.com/etcd-io/etcd/pull/14120) option by default to improve +etcd store consistency guarantees. + +This options is only available with etcd >= v3.5.5, so Talos doesn't support version of etcd before v3.5.5. """ [make_deps] diff --git a/internal/app/machined/pkg/system/services/etcd.go b/internal/app/machined/pkg/system/services/etcd.go index 15419e371..c3b1d5ef8 100644 --- a/internal/app/machined/pkg/system/services/etcd.go +++ b/internal/app/machined/pkg/system/services/etcd.go @@ -409,6 +409,7 @@ func (e *Etcd) argsForInit(ctx context.Context, r runtime.Runtime, spec *etcdres "peer-trusted-ca-file": constants.EtcdCACert, "experimental-initial-corrupt-check": "true", "experimental-watch-progress-notify-interval": "5s", + "experimental-compact-hash-check-enabled": "true", } extraArgs := argsbuilder.Args(r.Config().Cluster().Etcd().ExtraArgs()) @@ -485,6 +486,7 @@ func (e *Etcd) argsForControlPlane(ctx context.Context, r runtime.Runtime, spec "peer-trusted-ca-file": constants.EtcdCACert, "experimental-initial-corrupt-check": "true", "experimental-watch-progress-notify-interval": "5s", + "experimental-compact-hash-check-enabled": "true", } extraArgs := argsbuilder.Args(r.Config().Cluster().Etcd().ExtraArgs())