mirrors/talos
1
0
Fork 0
mirror of https://github.com/siderolabs/talos.git synced 2025-12-17 07:21:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: fix dns test in race mode

Browse Source 
This is a workaround, as using `t.Context()` causes panics as `t.Log` is
used after the test finishes, this is related to unsynchronized
context.AfterFunc, but I will leave the fix to @DmitryMV.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
This commit is contained in:
Andrey Smirnov 2025-03-06 15:49:34 +04:00
parent 17965c32fa
commit c3c0d2e42f
No known key found for this signature in database
GPG Key ID: FE042E3D4085A811
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/pkg/dns/dns_test.go
View File

@ -128,9 +128,9 @@ func TestGC_NOGC(t *testing.T) {
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
m := dns.NewManager(&testReader{}, func(e suture.Event) { t.Log("dns-runners event:", e) }, zaptest.NewLogger(t)) m := dns.NewManager(&testReader{}, func(e suture.Event) { t.Log("dns-runners event:", e) }, zaptest.NewLogger(t))
m.ServeBackground(t.Context()) m.ServeBackground(context.Background()) //nolint:usetesting
m.ServeBackground(t.Context()) m.ServeBackground(context.Background()) //nolint:usetesting
require.Panics(t, func() { m.ServeBackground(context.Background()) }) //nolint:usetesting // need background context to trigger panic require.Panics(t, func() { m.ServeBackground(context.TODO()) }) //nolint:usetesting
for _, err := range m.RunAll(slices.Values([]dns.AddressPair{ for _, err := range m.RunAll(slices.Values([]dns.AddressPair{
{Network: "udp", Addr: netip.MustParseAddrPort("127.0.0.1:10700")}, {Network: "udp", Addr: netip.MustParseAddrPort("127.0.0.1:10700")},
@ -172,7 +172,7 @@ func newManager(t *testing.T, nameservers ...string) func() {
return p return p
}) })
ctx, cancel := context.WithCancel(t.Context()) ctx, cancel := context.WithCancel(context.Background()) //nolint:usetesting
t.Cleanup(cancel) t.Cleanup(cancel)
m.SetUpstreams(slices.Values(pxs)) m.SetUpstreams(slices.Values(pxs))