mirrors/talos
1
0
Fork 0
mirror of https://github.com/siderolabs/talos.git synced 2026-05-04 12:01:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: stale discovered volume children

Browse Source 
Fix a race when a parent disappearing doesn't clean up children
(partitions) based on the order of reconciliation events - a timer-based
one, and a notification about disk.

Treat a disappearing (failing) parent as a signal to clean up all
children as well.

Fixes #13259

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
This commit is contained in:
Andrey Smirnov 2026-05-01 21:25:46 +04:00
parent 13ce018795
commit a349dac036
No known key found for this signature in database
GPG Key ID: 322C6F63F594CE7C
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/app/machined/pkg/controllers/block/discovery.go
View File

@ -290,15 +290,15 @@ func (ctrl *DiscoveryController) rescan(ctx context.Context, r controller.Runtim
_, isFailed := failedIDs[dv.Metadata().ID()]
parentTouched := false
parentFailed := false
if dv.TypedSpec().Parent != "" {
if _, ok := touchedIDs[dv.TypedSpec().Parent]; ok {
parentTouched = true
}
_, parentTouched = touchedIDs[dv.TypedSpec().Parent]
_, parentFailed = failedIDs[dv.TypedSpec().Parent]
}
if isFailed || parentTouched {
// if the probe failed, or if the parent was touched, while this device was not, remove it
if isFailed || parentTouched || parentFailed {
// if the probe failed, or if the parent was touched/failed, while this device was not, remove it
if err = r.Destroy(ctx, dv.Metadata()); err != nil {
return nil, fmt.Errorf("failed to destroy discovered volume: %w", err)
}