From 7c4e47c0c00e740bf0d63521baa1231354bc1966 Mon Sep 17 00:00:00 2001 From: Andrey Smirnov Date: Thu, 27 Feb 2025 20:33:31 +0400 Subject: [PATCH] chore: stop doing generate on each build Right now any build would internally trigger `generate` even if someone forgot to do `make generate`. This causes excessive over-generation many times during the build as any change to `pkg/` invalidates the cache. Fix that by dropping this over-generation. Our CI checks for dirtiness anyways (missing `make generate`). Idea: Noel. Signed-off-by: Andrey Smirnov --- Dockerfile | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Dockerfile b/Dockerfile index 65c6a0927..452d52fdb 100644 --- a/Dockerfile +++ b/Dockerfile @@ -444,16 +444,11 @@ FROM build-go AS base COPY ./cmd ./cmd COPY ./pkg ./pkg COPY ./internal ./internal -COPY --from=generate /pkg/flannel/ ./pkg/flannel/ -COPY --from=generate /pkg/imager/ ./pkg/imager/ -COPY --from=generate /pkg/machinery/ ./pkg/machinery/ -COPY --from=generate /internal/app/machined/pkg/controllers/secrets/data/ ./internal/app/machined/pkg/controllers/secrets/data/ -COPY --from=generate /internal/pkg/secureboot/database/certs/ ./internal/pkg/secureboot/database/certs/ -COPY --from=generate /internal/pkg/selinux/ ./internal/pkg/selinux/ COPY --from=embed / ./ RUN --mount=type=cache,target=/.cache go list all >/dev/null WORKDIR /src/pkg/machinery RUN --mount=type=cache,target=/.cache go list all >/dev/null +RUN --mount=type=cache,target=/.cache go generate -v ./version WORKDIR /src # The vulncheck target runs the vulnerability check tool.