mirrors/talos
1
0
Fork 0
mirror of https://github.com/siderolabs/talos.git synced 2025-12-08 02:51:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: fix "defer" leak in ResetUserDisks

Browse Source 
Also, print error if we failed to close the device.

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
This commit is contained in:
Dmitriy Matrenichev 2023-02-28 17:26:00 +03:00
parent bfba3677b0
commit 638dc9128f
No known key found for this signature in database
GPG Key ID: D3363CF894E68892
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
internal/app/machined/pkg/runtime/v1alpha1/v1alpha1_sequencer_tasks.go
View File

@ -1634,27 +1634,36 @@ func ResetSystemDisk(seq runtime.Sequence, data interface{}) (runtime.TaskExecut
}
// ResetUserDisks represents the task to reset the user disks.
func ResetUserDisks(seq runtime.Sequence, data interface{}) (runtime.TaskExecutionFunc, string) {
func ResetUserDisks(_ runtime.Sequence, data any) (runtime.TaskExecutionFunc, string) {
return func(ctx context.Context, logger *log.Logger, r runtime.Runtime) (err error) {
in, ok := data.(runtime.ResetOptions)
if !ok {
return fmt.Errorf("unexpected runtime data")
}
for _, deviceName := range in.GetUserDisksToWipe() {
var dev *blockdevice.BlockDevice
dev, err = blockdevice.Open(deviceName)
wipeDevice := func(deviceName string) error {
dev, err := blockdevice.Open(deviceName)
if err != nil {
return err
}
defer dev.Close() //nolint:errcheck
defer func() {
if closeErr := dev.Close(); closeErr != nil {
logger.Printf("failed to close device %s: %s", deviceName, closeErr)
}
}()
logger.Printf("wiping user disk %s", deviceName)
err = dev.FastWipe()
if err != nil {
if err = dev.FastWipe(); err != nil {
return err
}
return nil
}
for _, deviceName := range in.GetUserDisksToWipe() {
if err := wipeDevice(deviceName); err != nil {
return err
}
}