From 21f459aab5d8ac2841aa69a9237ca3faa06da7df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Knecht?= Date: Wed, 8 Apr 2026 20:00:25 +0200 Subject: [PATCH] fix(talosctl): always use default GRPC dial options MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When run in "normal" mode, `talosctl` takes into account proxy configuration, such as the `https_proxy` and `no_proxy` environment variables; but when invoked with `--insecure`, those would be ignored, which results in `talosctl` being unable to interact with nodes in maintenance mode if they're only reachable through a proxy. This commit adds the `WithDefaultGRPCDialOptions()` option to the client created by `WithClientMaintenance()`, same as `WithClient()`. Signed-off-by: Benoît Knecht --- cmd/talosctl/pkg/talos/global/client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/talosctl/pkg/talos/global/client.go b/cmd/talosctl/pkg/talos/global/client.go index bcbb5b073..3aa7471ba 100644 --- a/cmd/talosctl/pkg/talos/global/client.go +++ b/cmd/talosctl/pkg/talos/global/client.go @@ -152,7 +152,7 @@ func (c *Args) WithClientMaintenance(enforceFingerprints []string, action func(c tlsConfig.VerifyConnection = x509.MatchSPKIFingerprints(fingerprints...) } - c, err := client.New(ctx, client.WithTLSConfig(tlsConfig), client.WithEndpoints(c.Nodes...)) + c, err := client.New(ctx, client.WithDefaultGRPCDialOptions(), client.WithTLSConfig(tlsConfig), client.WithEndpoints(c.Nodes...)) if err != nil { return err }