mirror of
https://github.com/tailscale/tailscale.git
synced 2025-09-21 13:41:46 +02:00
This is step 1 of ~3, breaking up #14720 into reviewable chunks, with the aim to make syspolicy be a build-time configurable feature. In this first (very noisy) step, all the syspolicy string key constants move to a new constant-only (code-free) package. This will make future steps more reviewable, without this movement noise. There are no code or behavior changes here. The future steps of this series can be seen in #14720: removing global funcs from syspolicy resolution and using an interface that's plumbed around instead. Then adding build tags. Updates #12614 Change-Id: If73bf2c28b9c9b1a408fe868b0b6a25b03eeabd1 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
115 lines
3.6 KiB
Go
115 lines
3.6 KiB
Go
// Copyright (c) Tailscale Inc & AUTHORS
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package syspolicy
|
|
|
|
import (
|
|
"tailscale.com/util/syspolicy/pkey"
|
|
"tailscale.com/util/syspolicy/rsop"
|
|
"tailscale.com/util/syspolicy/setting"
|
|
"tailscale.com/util/syspolicy/source"
|
|
"tailscale.com/util/testenv"
|
|
)
|
|
|
|
// TODO(nickkhyl): delete this file once other repos are updated.
|
|
|
|
// Handler reads system policies from OS-specific storage.
|
|
//
|
|
// Deprecated: implementing a [source.Store] should be preferred.
|
|
type Handler interface {
|
|
// ReadString reads the policy setting's string value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadString(key string) (string, error)
|
|
// ReadUInt64 reads the policy setting's uint64 value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadUInt64(key string) (uint64, error)
|
|
// ReadBool reads the policy setting's boolean value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadBoolean(key string) (bool, error)
|
|
// ReadStringArray reads the policy setting's string array value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadStringArray(key string) ([]string, error)
|
|
}
|
|
|
|
// RegisterHandler wraps and registers the specified handler as the device's
|
|
// policy [source.Store] for the program's lifetime.
|
|
//
|
|
// Deprecated: using [RegisterStore] should be preferred.
|
|
func RegisterHandler(h Handler) {
|
|
rsop.RegisterStore("DeviceHandler", setting.DeviceScope, WrapHandler(h))
|
|
}
|
|
|
|
// SetHandlerForTest wraps and sets the specified handler as the device's policy
|
|
// [source.Store] for the duration of tb.
|
|
//
|
|
// Deprecated: using [MustRegisterStoreForTest] should be preferred.
|
|
func SetHandlerForTest(tb testenv.TB, h Handler) {
|
|
RegisterWellKnownSettingsForTest(tb)
|
|
MustRegisterStoreForTest(tb, "DeviceHandler-TestOnly", setting.DefaultScope(), WrapHandler(h))
|
|
}
|
|
|
|
var _ source.Store = (*handlerStore)(nil)
|
|
|
|
// handlerStore is a [source.Store] that calls the underlying [Handler].
|
|
//
|
|
// TODO(nickkhyl): remove it when the corp and android repos are updated.
|
|
type handlerStore struct {
|
|
h Handler
|
|
}
|
|
|
|
// WrapHandler returns a [source.Store] that wraps the specified [Handler].
|
|
func WrapHandler(h Handler) source.Store {
|
|
return handlerStore{h}
|
|
}
|
|
|
|
// Lock implements [source.Lockable].
|
|
func (s handlerStore) Lock() error {
|
|
if lockable, ok := s.h.(source.Lockable); ok {
|
|
return lockable.Lock()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Unlock implements [source.Lockable].
|
|
func (s handlerStore) Unlock() {
|
|
if lockable, ok := s.h.(source.Lockable); ok {
|
|
lockable.Unlock()
|
|
}
|
|
}
|
|
|
|
// RegisterChangeCallback implements [source.Changeable].
|
|
func (s handlerStore) RegisterChangeCallback(callback func()) (unregister func(), err error) {
|
|
if changeable, ok := s.h.(source.Changeable); ok {
|
|
return changeable.RegisterChangeCallback(callback)
|
|
}
|
|
return func() {}, nil
|
|
}
|
|
|
|
// ReadString implements [source.Store].
|
|
func (s handlerStore) ReadString(key pkey.Key) (string, error) {
|
|
return s.h.ReadString(string(key))
|
|
}
|
|
|
|
// ReadUInt64 implements [source.Store].
|
|
func (s handlerStore) ReadUInt64(key pkey.Key) (uint64, error) {
|
|
return s.h.ReadUInt64(string(key))
|
|
}
|
|
|
|
// ReadBoolean implements [source.Store].
|
|
func (s handlerStore) ReadBoolean(key pkey.Key) (bool, error) {
|
|
return s.h.ReadBoolean(string(key))
|
|
}
|
|
|
|
// ReadStringArray implements [source.Store].
|
|
func (s handlerStore) ReadStringArray(key pkey.Key) ([]string, error) {
|
|
return s.h.ReadStringArray(string(key))
|
|
}
|
|
|
|
// Done implements [source.Expirable].
|
|
func (s handlerStore) Done() <-chan struct{} {
|
|
if expirable, ok := s.h.(source.Expirable); ok {
|
|
return expirable.Done()
|
|
}
|
|
return nil
|
|
}
|