mirror of
https://github.com/tailscale/tailscale.git
synced 2025-08-06 14:17:23 +02:00
b70c0c50fd
In tailssh.go:1284, (*sshSession).startNewRecording starts a fire-and-forget goroutine that can outlive the test that triggered its creation. Among other things, it uses ss.logf, and may call it after the test has already returned. Since we typically use (*testing.T).Logf as the logger, this results in a data race and causes flaky tests. Ideally, we should fix the root cause and/or use a goroutines.Tracker to wait for the goroutine to complete. But with the release approaching, it's too risky to make such changes now. As a workaround, we update the tests to use tstest.WhileTestRunningLogger, which logs to t.Logf while the test is running and disables logging once the test finishes, avoiding the race. While there, we also fix TestSSHAuthFlow not to use log.Printf. Updates #15568 Updates #7707 (probably related) Signed-off-by: Nick Khyl <nickk@tailscale.com> |
||
|---|---|---|
| .. | ||
| testcontainers | ||
| accept_env_test.go | ||
| accept_env.go | ||
| incubator_linux.go | ||
| incubator_plan9.go | ||
| incubator.go | ||
| privs_test.go | ||
| tailssh_integration_test.go | ||
| tailssh_test.go | ||
| tailssh.go | ||
| user.go | ||