tailscale

mirror of https://github.com/tailscale/tailscale.git synced 2025-09-21 13:41:46 +02:00

History

Alex Chan 63d07db733 cmd/tailscale/cli: fix race condition in up --force-reauth

This commit fixes a race condition where `tailscale up --force-reauth` would
exit prematurely on an already-logged in device.

Previously, the CLI would wait for IPN to report the "Running" state and then
exit. However, this could happen before the new auth URL was printed, leading
to two distinct issues:

*   **Without seamless key renewal:** The CLI could exit immediately after
    the `StartLoginInteractive` call, before IPN has time to switch into
    the "Starting" state or send a new auth URL back to the CLI.
*   **With seamless key renewal:** IPN stays in the "Running" state
    throughout the process, so the CLI exits immediately without performing
    any reauthentication.

The fix is to change the CLI's exit condition.

Instead of waiting for the "Running" state, if we're doing a `--force-reauth`
we now wait to see the node key change, which is a more reliable indicator
that a successful authentication has occurred.

Updates tailscale/corp#31476
Updates tailscale/tailscale#17108

Signed-off-by: Alex Chan <alexc@tailscale.com>

2025-09-17 12:33:39 +01:00

auto.go

control/controlclient: introduce eventbus messages instead of callbacks (#16956 )

2025-09-15 10:36:17 -04:00

client.go

control/controlclient: introduce eventbus messages instead of callbacks (#16956 )

2025-09-15 10:36:17 -04:00

controlclient_test.go

health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085 )

2025-09-16 11:25:29 -04:00

direct_test.go

control/controlclient: introduce eventbus messages instead of callbacks (#16956 )