mirror of
				https://github.com/tailscale/tailscale.git
				synced 2025-10-31 16:22:03 +01:00 
			
		
		
		
	Previously, if we had a umask set (e.g. 0027) that prevented creating a world-readable file, /etc/resolv.conf would be created without the o+r bit and thus other users may be unable to resolve DNS. Since a umask only applies to file creation, chmod the file after creation and before renaming it to ensure that it has the appropriate permissions. Updates #12609 Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: I2a05d64f4f3a8ee8683a70be17a7da0e70933137
		
			
				
	
	
		
			240 lines
		
	
	
		
			6.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			240 lines
		
	
	
		
			6.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright (c) Tailscale Inc & AUTHORS
 | |
| // SPDX-License-Identifier: BSD-3-Clause
 | |
| 
 | |
| package dns
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"context"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"os"
 | |
| 	"os/exec"
 | |
| 	"os/user"
 | |
| 	"strings"
 | |
| 	"syscall"
 | |
| 	"time"
 | |
| 
 | |
| 	"golang.org/x/sys/windows"
 | |
| 	"tailscale.com/health"
 | |
| 	"tailscale.com/types/logger"
 | |
| 	"tailscale.com/util/winutil"
 | |
| )
 | |
| 
 | |
| // wslDistros reports the names of the installed WSL2 linux distributions.
 | |
| func wslDistros() ([]string, error) {
 | |
| 	// There is a bug in some builds of wsl.exe that causes it to block
 | |
| 	// indefinitely while executing this operation. Set a timeout so that we don't
 | |
| 	// get wedged! (Issue #7476)
 | |
| 	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 | |
| 	defer cancel()
 | |
| 
 | |
| 	b, err := wslCombinedOutput(exec.CommandContext(ctx, "wsl.exe", "-l"))
 | |
| 	if err != nil {
 | |
| 		return nil, fmt.Errorf("%v: %q", err, string(b))
 | |
| 	}
 | |
| 
 | |
| 	lines := strings.Split(string(b), "\n")
 | |
| 	if len(lines) < 1 {
 | |
| 		return nil, nil
 | |
| 	}
 | |
| 	lines = lines[1:] // drop "Windows Subsystem For Linux" header
 | |
| 
 | |
| 	var distros []string
 | |
| 	for _, name := range lines {
 | |
| 		name = strings.TrimSpace(name)
 | |
| 		name = strings.TrimSuffix(name, " (Default)")
 | |
| 		if name == "" {
 | |
| 			continue
 | |
| 		}
 | |
| 		distros = append(distros, name)
 | |
| 	}
 | |
| 	return distros, nil
 | |
| }
 | |
| 
 | |
| // wslManager is a DNS manager for WSL2 linux distributions.
 | |
| // It configures /etc/wsl.conf and /etc/resolv.conf.
 | |
| type wslManager struct {
 | |
| 	logf   logger.Logf
 | |
| 	health *health.Tracker
 | |
| }
 | |
| 
 | |
| func newWSLManager(logf logger.Logf, health *health.Tracker) *wslManager {
 | |
| 	m := &wslManager{
 | |
| 		logf:   logf,
 | |
| 		health: health,
 | |
| 	}
 | |
| 	return m
 | |
| }
 | |
| 
 | |
| func (wm *wslManager) SetDNS(cfg OSConfig) error {
 | |
| 	distros, err := wslDistros()
 | |
| 	if err != nil {
 | |
| 		return err
 | |
| 	} else if len(distros) == 0 {
 | |
| 		return nil
 | |
| 	}
 | |
| 	managers := make(map[string]*directManager)
 | |
| 	for _, distro := range distros {
 | |
| 		managers[distro] = newDirectManagerOnFS(wm.logf, wm.health, wslFS{
 | |
| 			user:   "root",
 | |
| 			distro: distro,
 | |
| 		})
 | |
| 	}
 | |
| 
 | |
| 	if !cfg.IsZero() {
 | |
| 		if wm.setWSLConf(managers) {
 | |
| 			// What's this? So glad you asked.
 | |
| 			//
 | |
| 			// WSL2 writes the /etc/resolv.conf.
 | |
| 			// It is aggressive about it. Every time you execute wsl.exe,
 | |
| 			// it writes it. (Opening a terminal is done by running wsl.exe.)
 | |
| 			// You can turn this off using /etc/wsl.conf! But: this wsl.conf
 | |
| 			// file is only parsed when the VM boots up. To do that, we
 | |
| 			// have to shut down WSL2.
 | |
| 			//
 | |
| 			// So we do it here, before we call wsl.exe to write resolv.conf.
 | |
| 			if b, err := wslCombinedOutput(wslCommand("--shutdown")); err != nil {
 | |
| 				wm.logf("WSL SetDNS shutdown: %v: %s", err, b)
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	for distro, m := range managers {
 | |
| 		if err := m.SetDNS(cfg); err != nil {
 | |
| 			wm.logf("WSL(%q) SetDNS: %v", distro, err)
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| const wslConf = "/etc/wsl.conf"
 | |
| const wslConfSection = `# added by tailscale
 | |
| [network]
 | |
| generateResolvConf = false
 | |
| `
 | |
| 
 | |
| // setWSLConf attempts to disable generateResolvConf in each WSL2 linux.
 | |
| // If any are changed, it reports true.
 | |
| func (wm *wslManager) setWSLConf(managers map[string]*directManager) (changed bool) {
 | |
| 	for distro, m := range managers {
 | |
| 		b, err := m.fs.ReadFile(wslConf)
 | |
| 		if err != nil && !os.IsNotExist(err) {
 | |
| 			wm.logf("WSL(%q) wsl.conf: read: %v", distro, err)
 | |
| 			continue
 | |
| 		}
 | |
| 		ini := parseIni(string(b))
 | |
| 		if v := ini["network"]["generateResolvConf"]; v == "" {
 | |
| 			b = append(b, wslConfSection...)
 | |
| 			if err := m.fs.WriteFile(wslConf, b, 0644); err != nil {
 | |
| 				wm.logf("WSL(%q) wsl.conf: write: %v", distro, err)
 | |
| 				continue
 | |
| 			}
 | |
| 			changed = true
 | |
| 		}
 | |
| 	}
 | |
| 	return changed
 | |
| }
 | |
| 
 | |
| func (m *wslManager) SupportsSplitDNS() bool { return false }
 | |
| func (m *wslManager) Close() error           { return m.SetDNS(OSConfig{}) }
 | |
| 
 | |
| // wslFS is a pinholeFS implemented on top of wsl.exe.
 | |
| //
 | |
| // We access WSL2 file systems via wsl.exe instead of \\wsl$\ because
 | |
| // the netpath appears to operate as the standard user, not root.
 | |
| type wslFS struct {
 | |
| 	user   string
 | |
| 	distro string
 | |
| }
 | |
| 
 | |
| func (fs wslFS) Stat(name string) (isRegular bool, err error) {
 | |
| 	err = wslRun(fs.cmd("test", "-f", name))
 | |
| 	if ee, _ := err.(*exec.ExitError); ee != nil {
 | |
| 		if ee.ExitCode() == 1 {
 | |
| 			return false, os.ErrNotExist
 | |
| 		}
 | |
| 		return false, err
 | |
| 	}
 | |
| 	return true, nil
 | |
| }
 | |
| 
 | |
| func (fs wslFS) Chmod(name string, perm os.FileMode) error {
 | |
| 	return wslRun(fs.cmd("chmod", "--", fmt.Sprintf("%04o", perm), name))
 | |
| }
 | |
| 
 | |
| func (fs wslFS) Rename(oldName, newName string) error {
 | |
| 	return wslRun(fs.cmd("mv", "--", oldName, newName))
 | |
| }
 | |
| func (fs wslFS) Remove(name string) error { return wslRun(fs.cmd("rm", "--", name)) }
 | |
| 
 | |
| func (fs wslFS) Truncate(name string) error { return fs.WriteFile(name, nil, 0644) }
 | |
| 
 | |
| func (fs wslFS) ReadFile(name string) ([]byte, error) {
 | |
| 	b, err := wslCombinedOutput(fs.cmd("cat", "--", name))
 | |
| 	var ee *exec.ExitError
 | |
| 	if errors.As(err, &ee) && ee.ExitCode() == 1 {
 | |
| 		return nil, os.ErrNotExist
 | |
| 	}
 | |
| 	return b, err
 | |
| }
 | |
| 
 | |
| func (fs wslFS) WriteFile(name string, contents []byte, perm os.FileMode) error {
 | |
| 	cmd := fs.cmd("tee", "--", name)
 | |
| 	cmd.Stdin = bytes.NewReader(contents)
 | |
| 	cmd.Stdout = nil
 | |
| 	if err := wslRun(cmd); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	return wslRun(fs.cmd("chmod", "--", fmt.Sprintf("%04o", perm), name))
 | |
| }
 | |
| 
 | |
| func (fs wslFS) cmd(args ...string) *exec.Cmd {
 | |
| 	cmd := wslCommand("-u", fs.user, "-d", fs.distro, "-e")
 | |
| 	cmd.Args = append(cmd.Args, args...)
 | |
| 	return cmd
 | |
| }
 | |
| 
 | |
| func wslCommand(args ...string) *exec.Cmd {
 | |
| 	cmd := exec.Command("wsl.exe", args...)
 | |
| 	return cmd
 | |
| }
 | |
| 
 | |
| func wslCombinedOutput(cmd *exec.Cmd) ([]byte, error) {
 | |
| 	buf := new(bytes.Buffer)
 | |
| 	cmd.Stdout = buf
 | |
| 	cmd.Stderr = buf
 | |
| 	err := wslRun(cmd)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	return maybeUnUTF16(buf.Bytes()), nil
 | |
| }
 | |
| 
 | |
| func wslRun(cmd *exec.Cmd) (err error) {
 | |
| 	defer func() {
 | |
| 		if err != nil {
 | |
| 			err = fmt.Errorf("wslRun(%v): %w", cmd.Args, err)
 | |
| 		}
 | |
| 	}()
 | |
| 
 | |
| 	var token windows.Token
 | |
| 	if u, err := user.Current(); err == nil && u.Name == "SYSTEM" {
 | |
| 		// We need to switch user to run wsl.exe.
 | |
| 		// https://github.com/microsoft/WSL/issues/4803
 | |
| 		sessionID := winutil.WTSGetActiveConsoleSessionId()
 | |
| 		if sessionID != 0xFFFFFFFF {
 | |
| 			if err := windows.WTSQueryUserToken(sessionID, &token); err != nil {
 | |
| 				return err
 | |
| 			}
 | |
| 			defer token.Close()
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	cmd.SysProcAttr = &syscall.SysProcAttr{
 | |
| 		CreationFlags: windows.CREATE_NO_WINDOW,
 | |
| 		Token:         syscall.Token(token),
 | |
| 	}
 | |
| 	return cmd.Run()
 | |
| }
 |