Avery Pennarun effbe67fe3 wgengine/magicsock: remove pickPort, use port 0 to avoid TOCTOU race ...

pickPort would bind a UDP socket on :0 to get a free port, close
the socket, then hope to rebind to the same port in NewConn. This
is a TOCTOU race that can cause flaky test failures when another
process grabs the port in between.

Instead, pass Port: 0 to NewConn and let the OS assign the port
atomically, then read back the assigned port via conn.LocalPort().

Fixes #19409

Change-Id: Ie44b599fb93c361e29a05f2171ad747c46f82b7a
Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>

2026-04-14 18:08:47 -07:00

..

bench

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

filter

all: use Go 1.26 things, run most gofix modernizers

2026-03-06 13:32:03 -08:00

magicsock

wgengine/magicsock: remove pickPort, use port 0 to avoid TOCTOU race

2026-04-14 18:08:47 -07:00

netlog

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

netstack

all: fix six tests that failed with -count=2

2026-04-13 18:52:57 -07:00

router

util/linuxfw,wgengine/router: allow incoming CGNAT range traffic with nodeattr

2026-04-14 16:45:06 -04:00

wgcfg

cmd/vet: add subtestnames analyzer; fix all existing violations

2026-04-05 15:52:51 -07:00

wgint

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

wglog

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

winnet

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

mem_ios.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

pendopen_omit.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

pendopen.go

all: use bart.Lite instead of bart.Table where appropriate

2026-03-24 14:45:23 +00:00

userspace_ext_test.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

userspace_test.go

wgengine: replace reflect.DeepEqual with typed Equal for maybeReconfigInputs (#19365)

2026-04-14 13:16:21 -04:00

userspace.go

wgengine: replace reflect.DeepEqual with typed Equal for maybeReconfigInputs (#19365)

2026-04-14 13:16:21 -04:00

watchdog_omit.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00

watchdog_test.go

cmd/vet: add subtestnames analyzer; fix all existing violations

2026-04-05 15:52:51 -07:00

watchdog.go

control/controlclient,ipn/ipnlocal,wgengine: avoid restarting wireguard when key is learned via tsmp (#19142)

2026-03-30 14:26:08 -04:00

wgengine.go

all: remove AUTHORS file and references to it

2026-01-23 15:49:45 -08:00