mirror of
https://github.com/tailscale/tailscale.git
synced 2026-02-09 09:41:49 +01:00
This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
163 lines
5.0 KiB
Go
163 lines
5.0 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
||
// SPDX-License-Identifier: BSD-3-Clause
|
||
|
||
package prober
|
||
|
||
import (
|
||
"context"
|
||
"crypto/tls"
|
||
"crypto/x509"
|
||
"errors"
|
||
"fmt"
|
||
"io"
|
||
"net/http"
|
||
"net/netip"
|
||
"slices"
|
||
"time"
|
||
)
|
||
|
||
const expiresSoon = 7 * 24 * time.Hour // 7 days from now
|
||
// Let’s Encrypt promises to issue certificates with CRL servers after 2025-05-07:
|
||
// https://letsencrypt.org/2024/12/05/ending-ocsp/
|
||
// https://github.com/tailscale/tailscale/issues/15912
|
||
const letsEncryptStartedStaplingCRL int64 = 1746576000 // 2025-05-07 00:00:00 UTC
|
||
|
||
// TLS returns a Probe that healthchecks a TLS endpoint.
|
||
//
|
||
// The ProbeFunc connects to a hostPort (host:port string), does a TLS
|
||
// handshake, verifies that the hostname matches the presented certificate,
|
||
// checks certificate validity time and OCSP revocation status.
|
||
//
|
||
// The TLS config is optional and may be nil.
|
||
func TLS(hostPort string, config *tls.Config) ProbeClass {
|
||
return ProbeClass{
|
||
Probe: func(ctx context.Context) error {
|
||
return probeTLS(ctx, config, hostPort)
|
||
},
|
||
Class: "tls",
|
||
}
|
||
}
|
||
|
||
// TLSWithIP is like TLS, but dials the provided dialAddr instead of using DNS
|
||
// resolution. Use config.ServerName to send SNI and validate the name in the
|
||
// cert.
|
||
func TLSWithIP(dialAddr netip.AddrPort, config *tls.Config) ProbeClass {
|
||
return ProbeClass{
|
||
Probe: func(ctx context.Context) error {
|
||
return probeTLS(ctx, config, dialAddr.String())
|
||
},
|
||
Class: "tls",
|
||
}
|
||
}
|
||
|
||
func probeTLS(ctx context.Context, config *tls.Config, dialHostPort string) error {
|
||
dialer := &tls.Dialer{Config: config}
|
||
conn, err := dialer.DialContext(ctx, "tcp", dialHostPort)
|
||
if err != nil {
|
||
return fmt.Errorf("connecting to %q: %w", dialHostPort, err)
|
||
}
|
||
defer conn.Close()
|
||
|
||
tlsConnState := conn.(*tls.Conn).ConnectionState()
|
||
return validateConnState(ctx, &tlsConnState)
|
||
}
|
||
|
||
// validateConnState verifies certificate validity time in all certificates
|
||
// returned by the TLS server and checks OCSP revocation status for the
|
||
// leaf cert.
|
||
func validateConnState(ctx context.Context, cs *tls.ConnectionState) (returnerr error) {
|
||
var errs []error
|
||
defer func() {
|
||
returnerr = errors.Join(errs...)
|
||
}()
|
||
latestAllowedExpiration := time.Now().Add(expiresSoon)
|
||
|
||
var leafCert *x509.Certificate
|
||
var issuerCert *x509.Certificate
|
||
var leafAuthorityKeyID string
|
||
// PeerCertificates will never be len == 0 on the client side
|
||
for i, cert := range cs.PeerCertificates {
|
||
if i == 0 {
|
||
leafCert = cert
|
||
leafAuthorityKeyID = string(cert.AuthorityKeyId)
|
||
}
|
||
if i > 0 {
|
||
if leafAuthorityKeyID == string(cert.SubjectKeyId) {
|
||
issuerCert = cert
|
||
}
|
||
}
|
||
|
||
// Do not check certificate validity period for self-signed certs.
|
||
// The practical reason is to avoid raising alerts for expiring
|
||
// DERP metaCert certificates that are returned as part of regular
|
||
// TLS handshake.
|
||
if string(cert.SubjectKeyId) == string(cert.AuthorityKeyId) {
|
||
continue
|
||
}
|
||
|
||
if time.Now().Before(cert.NotBefore) {
|
||
errs = append(errs, fmt.Errorf("one of the certs has NotBefore in the future (%v): %v", cert.NotBefore, cert.Subject))
|
||
}
|
||
if latestAllowedExpiration.After(cert.NotAfter) {
|
||
left := cert.NotAfter.Sub(time.Now())
|
||
errs = append(errs, fmt.Errorf("one of the certs expires in %v: %v", left, cert.Subject))
|
||
}
|
||
}
|
||
|
||
if len(leafCert.CRLDistributionPoints) == 0 {
|
||
if !slices.Contains(leafCert.Issuer.Organization, "Let's Encrypt") {
|
||
// LE certs contain a CRL, but certs from other CAs might not.
|
||
return
|
||
}
|
||
if leafCert.NotBefore.Before(time.Unix(letsEncryptStartedStaplingCRL, 0)) {
|
||
// Certificate might not have a CRL.
|
||
return
|
||
}
|
||
errs = append(errs, fmt.Errorf("no CRL server presented in leaf cert for %v", leafCert.Subject))
|
||
return
|
||
}
|
||
|
||
err := checkCertCRL(ctx, leafCert.CRLDistributionPoints[0], leafCert, issuerCert)
|
||
if err != nil {
|
||
errs = append(errs, fmt.Errorf("CRL verification failed for %v: %w", leafCert.Subject, err))
|
||
}
|
||
return
|
||
}
|
||
|
||
func checkCertCRL(ctx context.Context, crlURL string, leafCert, issuerCert *x509.Certificate) error {
|
||
hreq, err := http.NewRequestWithContext(ctx, "GET", crlURL, nil)
|
||
if err != nil {
|
||
return fmt.Errorf("could not create CRL GET request: %w", err)
|
||
}
|
||
hresp, err := http.DefaultClient.Do(hreq)
|
||
if err != nil {
|
||
return fmt.Errorf("CRL request failed: %w", err)
|
||
}
|
||
defer hresp.Body.Close()
|
||
if hresp.StatusCode != http.StatusOK {
|
||
return fmt.Errorf("crl: non-200 status code from CRL server: %s", hresp.Status)
|
||
}
|
||
lr := io.LimitReader(hresp.Body, 10<<20) // 10MB
|
||
crlB, err := io.ReadAll(lr)
|
||
if err != nil {
|
||
return err
|
||
}
|
||
|
||
crl, err := x509.ParseRevocationList(crlB)
|
||
if err != nil {
|
||
return fmt.Errorf("could not parse CRL: %w", err)
|
||
}
|
||
|
||
if err := crl.CheckSignatureFrom(issuerCert); err != nil {
|
||
return fmt.Errorf("could not verify CRL signature: %w", err)
|
||
}
|
||
|
||
for _, revoked := range crl.RevokedCertificateEntries {
|
||
if revoked.SerialNumber.Cmp(leafCert.SerialNumber) == 0 {
|
||
return fmt.Errorf("cert for %v has been revoked on %v, reason: %v", leafCert.Subject, revoked.RevocationTime, revoked.ReasonCode)
|
||
}
|
||
}
|
||
|
||
return nil
|
||
}
|