mirror of
https://github.com/tailscale/tailscale.git
synced 2026-02-09 17:52:57 +01:00
This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
126 lines
3.6 KiB
Go
126 lines
3.6 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
// Package ace implements a Dialer that dials via a Tailscale ACE (CONNECT)
|
|
// proxy.
|
|
//
|
|
// TODO: document this more, when it's more done. As of 2025-09-17, it's in
|
|
// development.
|
|
package ace
|
|
|
|
import (
|
|
"bufio"
|
|
"cmp"
|
|
"context"
|
|
"crypto/tls"
|
|
"errors"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"net/netip"
|
|
"sync/atomic"
|
|
)
|
|
|
|
// Dialer is an HTTP CONNECT proxy dialer to dial the control plane via an ACE
|
|
// proxy.
|
|
type Dialer struct {
|
|
ACEHost string
|
|
ACEHostIP netip.Addr // optional; if non-zero, use this IP instead of DNS
|
|
ACEPort int // zero means 443
|
|
|
|
// NetDialer optionally specifies the underlying dialer to use to reach the
|
|
// ACEHost. If nil, net.Dialer.DialContext is used.
|
|
NetDialer func(ctx context.Context, network, address string) (net.Conn, error)
|
|
}
|
|
|
|
func (d *Dialer) netDialer() func(ctx context.Context, network, address string) (net.Conn, error) {
|
|
if d.NetDialer != nil {
|
|
return d.NetDialer
|
|
}
|
|
var std net.Dialer
|
|
return std.DialContext
|
|
}
|
|
|
|
func (d *Dialer) acePort() int { return cmp.Or(d.ACEPort, 443) }
|
|
|
|
func (d *Dialer) Dial(ctx context.Context, network, address string) (_ net.Conn, err error) {
|
|
if network != "tcp" {
|
|
return nil, errors.New("only TCP is supported")
|
|
}
|
|
|
|
var targetHost string
|
|
if d.ACEHostIP.IsValid() {
|
|
targetHost = d.ACEHostIP.String()
|
|
} else {
|
|
targetHost = d.ACEHost
|
|
}
|
|
|
|
cc, err := d.netDialer()(ctx, "tcp", net.JoinHostPort(targetHost, fmt.Sprint(d.acePort())))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Now that we've dialed, we're about to do three potentially blocking
|
|
// operations: the TLS handshake, the CONNECT write, and the HTTP response
|
|
// read. To make our context work over all that, we use a context.AfterFunc
|
|
// to start a goroutine that'll tear down the underlying connection if the
|
|
// context expires.
|
|
//
|
|
// To prevent races, we use an atomic.Bool to guard access to the underlying
|
|
// connection being either good or bad. Only one goroutine (the success path
|
|
// in this goroutine after the ReadResponse or the AfterFunc's failure
|
|
// goroutine) will compare-and-swap it from false to true.
|
|
var done atomic.Bool
|
|
stop := context.AfterFunc(ctx, func() {
|
|
if done.CompareAndSwap(false, true) {
|
|
cc.Close()
|
|
}
|
|
})
|
|
defer func() {
|
|
if err != nil {
|
|
if ctx.Err() != nil {
|
|
// Prefer the context error. The other error is likely a side
|
|
// effect of the context expiring and our tearing down of the
|
|
// underlying connection, and is thus probably something like
|
|
// "use of closed network connection", which isn't useful (and
|
|
// actually misleading) for the caller.
|
|
err = ctx.Err()
|
|
}
|
|
stop()
|
|
cc.Close()
|
|
}
|
|
}()
|
|
|
|
tc := tls.Client(cc, &tls.Config{ServerName: d.ACEHost})
|
|
if err := tc.Handshake(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// TODO(tailscale/corp#32484): send proxy-auth header
|
|
if _, err := fmt.Fprintf(tc, "CONNECT %s HTTP/1.1\r\nHost: %s\r\n\r\n", address, d.ACEHost); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
br := bufio.NewReader(tc)
|
|
connRes, err := http.ReadResponse(br, &http.Request{Method: "CONNECT"})
|
|
if err != nil {
|
|
return nil, fmt.Errorf("reading CONNECT response: %w", err)
|
|
}
|
|
|
|
// Now that we're done with blocking operations, mark the connection
|
|
// as good, to prevent the context's AfterFunc from closing it.
|
|
if !stop() || !done.CompareAndSwap(false, true) {
|
|
// We lost a race and the context expired.
|
|
return nil, ctx.Err()
|
|
}
|
|
|
|
if connRes.StatusCode != http.StatusOK {
|
|
return nil, fmt.Errorf("ACE CONNECT response: %s", connRes.Status)
|
|
}
|
|
|
|
if br.Buffered() > 0 {
|
|
return nil, fmt.Errorf("unexpected %d bytes of buffered data after ACE CONNECT", br.Buffered())
|
|
}
|
|
return tc, nil
|
|
}
|