mirror of
https://github.com/tailscale/tailscale.git
synced 2026-02-11 10:41:43 +01:00
This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
167 lines
4.9 KiB
Go
167 lines
4.9 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package driveimpl
|
|
|
|
import (
|
|
"crypto/rand"
|
|
"crypto/subtle"
|
|
"encoding/hex"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"sync"
|
|
|
|
"github.com/tailscale/xnet/webdav"
|
|
"tailscale.com/drive/driveimpl/shared"
|
|
)
|
|
|
|
// FileServer is a standalone WebDAV server that dynamically serves up shares.
|
|
// It's typically used in a separate process from the actual Taildrive server to
|
|
// serve up files as an unprivileged user.
|
|
type FileServer struct {
|
|
ln net.Listener
|
|
secretToken string
|
|
shareHandlers map[string]http.Handler
|
|
sharesMu sync.RWMutex
|
|
}
|
|
|
|
// NewFileServer constructs a FileServer.
|
|
//
|
|
// The server attempts to listen at a random address on 127.0.0.1.
|
|
// The listen address is available via the Addr() method.
|
|
//
|
|
// The server has to be told about shares before it can serve them. This is
|
|
// accomplished either by calling SetShares(), or locking the shares with
|
|
// LockShares(), clearing them with ClearSharesLocked(), adding them
|
|
// individually with AddShareLocked(), and finally unlocking them with
|
|
// UnlockShares().
|
|
//
|
|
// The server doesn't actually process requests until the Serve() method is
|
|
// called.
|
|
func NewFileServer() (*FileServer, error) {
|
|
// path := filepath.Join(os.TempDir(), fmt.Sprintf("%v.socket", uuid.New().String()))
|
|
// ln, err := safesocket.Listen(path)
|
|
// if err != nil {
|
|
// TODO(oxtoacart): actually get safesocket working in more environments (MacOS Sandboxed, Windows, ???)
|
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("listen: %w", err)
|
|
}
|
|
|
|
secretToken, err := generateSecretToken()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &FileServer{
|
|
ln: ln,
|
|
secretToken: secretToken,
|
|
shareHandlers: make(map[string]http.Handler),
|
|
}, nil
|
|
}
|
|
|
|
// generateSecretToken generates a hex-encoded 256 bit secret.
|
|
func generateSecretToken() (string, error) {
|
|
tokenBytes := make([]byte, 32)
|
|
_, err := rand.Read(tokenBytes)
|
|
if err != nil {
|
|
return "", fmt.Errorf("generateSecretToken: %w", err)
|
|
}
|
|
return hex.EncodeToString(tokenBytes), nil
|
|
}
|
|
|
|
// Addr returns the address at which this FileServer is listening. This
|
|
// includes the secret token in front of the address, delimited by a pipe |.
|
|
func (s *FileServer) Addr() string {
|
|
return fmt.Sprintf("%s|%s", s.secretToken, s.ln.Addr().String())
|
|
}
|
|
|
|
// Serve() starts serving files and blocks until it encounters a fatal error.
|
|
func (s *FileServer) Serve() error {
|
|
return http.Serve(s.ln, s)
|
|
}
|
|
|
|
// LockShares locks the map of shares in preparation for manipulating it.
|
|
func (s *FileServer) LockShares() {
|
|
s.sharesMu.Lock()
|
|
}
|
|
|
|
// UnlockShares unlocks the map of shares.
|
|
func (s *FileServer) UnlockShares() {
|
|
s.sharesMu.Unlock()
|
|
}
|
|
|
|
// ClearSharesLocked clears the map of shares, assuming that LockShares() has
|
|
// been called first.
|
|
func (s *FileServer) ClearSharesLocked() {
|
|
s.shareHandlers = make(map[string]http.Handler)
|
|
}
|
|
|
|
// AddShareLocked adds a share to the map of shares, assuming that LockShares()
|
|
// has been called first.
|
|
func (s *FileServer) AddShareLocked(share, path string) {
|
|
s.shareHandlers[share] = &webdav.Handler{
|
|
FileSystem: &birthTimingFS{webdav.Dir(path)},
|
|
LockSystem: webdav.NewMemLS(),
|
|
}
|
|
}
|
|
|
|
// SetShares sets the full map of shares to the new value, mapping name->path.
|
|
func (s *FileServer) SetShares(shares map[string]string) {
|
|
s.LockShares()
|
|
defer s.UnlockShares()
|
|
s.ClearSharesLocked()
|
|
for name, path := range shares {
|
|
s.AddShareLocked(name, path)
|
|
}
|
|
}
|
|
|
|
// ServeHTTP implements the http.Handler interface. This requires a secret
|
|
// token in the path in order to prevent Mark-of-the-Web (MOTW) bypass attacks
|
|
// of the below sort:
|
|
//
|
|
// 1. Attacker with write access to the share puts a malicious file via
|
|
// http://100.100.100.100:8080/<tailnet>/<machine>/</share>/bad.exe
|
|
// 2. Attacker then induces victim to visit
|
|
// http://localhost:[PORT]/<share>/bad.exe
|
|
// 3. Because that is loaded from localhost, it does not get the MOTW
|
|
// thereby bypasses some OS-level security.
|
|
//
|
|
// The path on this file server is actually not as above, but rather
|
|
// http://localhost:[PORT]/<secretToken>/<share>/bad.exe. Unless the attacker
|
|
// can discover the secretToken, the attacker cannot craft a localhost URL that
|
|
// will work.
|
|
func (s *FileServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
parts := shared.CleanAndSplit(r.URL.Path)
|
|
|
|
token := parts[0]
|
|
a, b := []byte(token), []byte(s.secretToken)
|
|
if subtle.ConstantTimeCompare(a, b) != 1 {
|
|
w.WriteHeader(http.StatusForbidden)
|
|
return
|
|
}
|
|
|
|
if len(parts) < 2 {
|
|
w.WriteHeader(http.StatusBadRequest)
|
|
return
|
|
}
|
|
r.URL.Path = shared.Join(parts[2:]...)
|
|
share := parts[1]
|
|
s.sharesMu.RLock()
|
|
h, found := s.shareHandlers[share]
|
|
s.sharesMu.RUnlock()
|
|
if !found {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
return
|
|
}
|
|
// WebDAV's locking code compares the lock resources with the request's
|
|
// host header, set this to empty to avoid mismatches.
|
|
r.Host = ""
|
|
h.ServeHTTP(w, r)
|
|
}
|
|
|
|
func (s *FileServer) Close() error {
|
|
return s.ln.Close()
|
|
}
|