mirror of
https://github.com/tailscale/tailscale.git
synced 2026-02-09 17:52:57 +01:00
This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
189 lines
5.4 KiB
Go
189 lines
5.4 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package derphttp
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"time"
|
|
|
|
"tailscale.com/derp"
|
|
"tailscale.com/types/key"
|
|
"tailscale.com/types/logger"
|
|
)
|
|
|
|
var retryInterval = 5 * time.Second
|
|
|
|
// testHookWatchLookConnectResult, if non-nil for tests, is called by RunWatchConnectionLoop
|
|
// with the connect result. If it returns false, the loop ends.
|
|
var testHookWatchLookConnectResult func(connectError error, wasSelfConnect bool) (keepRunning bool)
|
|
|
|
// RunWatchConnectionLoop loops until ctx is done, sending
|
|
// WatchConnectionChanges and subscribing to connection changes.
|
|
//
|
|
// If the server's public key is ignoreServerKey, RunWatchConnectionLoop
|
|
// returns.
|
|
//
|
|
// Otherwise, the add and remove funcs are called as clients come & go.
|
|
// Note that add is called for every new connection and remove is only
|
|
// called for the final disconnection. See https://github.com/tailscale/tailscale/issues/13566.
|
|
// This behavior will likely change. Callers should do their own accounting
|
|
// and dup suppression as needed.
|
|
//
|
|
// If set the notifyError func is called with any error that occurs within the ctx
|
|
// main loop connection setup, or the inner loop receiving messages via RecvDetail.
|
|
//
|
|
// infoLogf, if non-nil, is the logger to write periodic status updates about
|
|
// how many peers are on the server. Error log output is set to the c's logger,
|
|
// regardless of infoLogf's value.
|
|
//
|
|
// To force RunWatchConnectionLoop to return quickly, its ctx needs to be
|
|
// closed, and c itself needs to be closed.
|
|
//
|
|
// It is a fatal error to call this on an already-started Client without having
|
|
// initialized Client.WatchConnectionChanges to true.
|
|
//
|
|
// If the DERP connection breaks and reconnects, remove will be called for all
|
|
// previously seen peers, with Reason type PeerGoneReasonMeshConnBroke. Those
|
|
// clients are likely still connected and their add message will appear after
|
|
// reconnect.
|
|
func (c *Client) RunWatchConnectionLoop(ctx context.Context, ignoreServerKey key.NodePublic, infoLogf logger.Logf,
|
|
add func(derp.PeerPresentMessage), remove func(derp.PeerGoneMessage), notifyError func(error)) {
|
|
if !c.WatchConnectionChanges {
|
|
if c.isStarted() {
|
|
panic("invalid use of RunWatchConnectionLoop on already-started Client without setting Client.RunWatchConnectionLoop")
|
|
}
|
|
c.WatchConnectionChanges = true
|
|
}
|
|
if infoLogf == nil {
|
|
infoLogf = logger.Discard
|
|
}
|
|
logf := c.logf
|
|
const statusInterval = 10 * time.Second
|
|
var (
|
|
mu sync.Mutex
|
|
present = map[key.NodePublic]bool{}
|
|
loggedConnected = false
|
|
)
|
|
clear := func() {
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
if len(present) == 0 {
|
|
return
|
|
}
|
|
logf("reconnected; clearing %d forwarding mappings", len(present))
|
|
for k := range present {
|
|
remove(derp.PeerGoneMessage{Peer: k, Reason: derp.PeerGoneReasonMeshConnBroke})
|
|
}
|
|
present = map[key.NodePublic]bool{}
|
|
}
|
|
lastConnGen := 0
|
|
lastStatus := c.clock.Now()
|
|
logConnectedLocked := func() {
|
|
if loggedConnected {
|
|
return
|
|
}
|
|
infoLogf("connected; %d peers", len(present))
|
|
loggedConnected = true
|
|
}
|
|
|
|
const logConnectedDelay = 200 * time.Millisecond
|
|
timer := c.clock.AfterFunc(2*time.Second, func() {
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
logConnectedLocked()
|
|
})
|
|
defer timer.Stop()
|
|
|
|
updatePeer := func(k key.NodePublic, isPresent bool) {
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
if isPresent {
|
|
present[k] = true
|
|
if !loggedConnected {
|
|
timer.Reset(logConnectedDelay)
|
|
}
|
|
} else {
|
|
// If we got a peerGone message, that means the initial connection's
|
|
// flood of peerPresent messages is done, so we can log already:
|
|
logConnectedLocked()
|
|
delete(present, k)
|
|
}
|
|
}
|
|
|
|
sleep := func(d time.Duration) {
|
|
t, tChannel := c.clock.NewTimer(d)
|
|
select {
|
|
case <-ctx.Done():
|
|
t.Stop()
|
|
case <-tChannel:
|
|
}
|
|
}
|
|
|
|
for ctx.Err() == nil {
|
|
// Make sure we're connected before calling s.ServerPublicKey.
|
|
_, _, err := c.connect(ctx, "RunWatchConnectionLoop")
|
|
if err != nil {
|
|
logf("mesh connect: %v", err)
|
|
if notifyError != nil {
|
|
notifyError(err)
|
|
}
|
|
if f := testHookWatchLookConnectResult; f != nil && !f(err, false) {
|
|
return
|
|
}
|
|
logf("mesh connect: %v", err)
|
|
sleep(retryInterval)
|
|
continue
|
|
}
|
|
selfConnect := c.ServerPublicKey() == ignoreServerKey
|
|
if f := testHookWatchLookConnectResult; f != nil && !f(err, selfConnect) {
|
|
return
|
|
}
|
|
if selfConnect {
|
|
logf("detected self-connect; ignoring host")
|
|
return
|
|
}
|
|
for {
|
|
m, connGen, err := c.RecvDetail()
|
|
if err != nil {
|
|
clear()
|
|
logf("Recv: %v", err)
|
|
if notifyError != nil {
|
|
notifyError(err)
|
|
}
|
|
sleep(retryInterval)
|
|
break
|
|
}
|
|
if connGen != lastConnGen {
|
|
lastConnGen = connGen
|
|
clear()
|
|
}
|
|
switch m := m.(type) {
|
|
case derp.PeerPresentMessage:
|
|
add(m)
|
|
updatePeer(m.Key, true)
|
|
case derp.PeerGoneMessage:
|
|
switch m.Reason {
|
|
case derp.PeerGoneReasonDisconnected:
|
|
// Normal case, log nothing
|
|
case derp.PeerGoneReasonNotHere:
|
|
logf("Recv: peer %s not connected to %s",
|
|
key.NodePublic(m.Peer).ShortString(), c.ServerPublicKey().ShortString())
|
|
default:
|
|
logf("Recv: peer %s not at server %s for unknown reason %v",
|
|
key.NodePublic(m.Peer).ShortString(), c.ServerPublicKey().ShortString(), m.Reason)
|
|
}
|
|
remove(m)
|
|
updatePeer(m.Peer, false)
|
|
default:
|
|
continue
|
|
}
|
|
if now := c.clock.Now(); now.Sub(lastStatus) > statusInterval {
|
|
lastStatus = now
|
|
infoLogf("%d peers", len(present))
|
|
}
|
|
}
|
|
}
|
|
}
|