mirror of
https://github.com/tailscale/tailscale.git
synced 2026-02-11 10:41:43 +01:00
This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>
172 lines
5.0 KiB
Go
172 lines
5.0 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
//go:build linux
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"log"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/fsnotify/fsnotify"
|
|
"tailscale.com/client/local"
|
|
"tailscale.com/ipn"
|
|
"tailscale.com/kube/certs"
|
|
"tailscale.com/kube/kubetypes"
|
|
klc "tailscale.com/kube/localclient"
|
|
"tailscale.com/types/netmap"
|
|
)
|
|
|
|
// watchServeConfigChanges watches path for changes, and when it sees one, reads
|
|
// the serve config from it, replacing ${TS_CERT_DOMAIN} with certDomain, and
|
|
// applies it to lc. It exits when ctx is canceled. cdChanged is a channel that
|
|
// is written to when the certDomain changes, causing the serve config to be
|
|
// re-read and applied.
|
|
func watchServeConfigChanges(ctx context.Context, cdChanged <-chan bool, certDomainAtomic *atomic.Pointer[string], lc *local.Client, kc *kubeClient, cfg *settings) {
|
|
if certDomainAtomic == nil {
|
|
panic("certDomainAtomic must not be nil")
|
|
}
|
|
|
|
var tickChan <-chan time.Time
|
|
var eventChan <-chan fsnotify.Event
|
|
if w, err := fsnotify.NewWatcher(); err != nil {
|
|
// Creating a new fsnotify watcher would fail for example if inotify was not able to create a new file descriptor.
|
|
// See https://github.com/tailscale/tailscale/issues/15081
|
|
log.Printf("serve proxy: failed to create fsnotify watcher, timer-only mode: %v", err)
|
|
ticker := time.NewTicker(5 * time.Second)
|
|
defer ticker.Stop()
|
|
tickChan = ticker.C
|
|
} else {
|
|
defer w.Close()
|
|
if err := w.Add(filepath.Dir(cfg.ServeConfigPath)); err != nil {
|
|
log.Fatalf("serve proxy: failed to add fsnotify watch: %v", err)
|
|
}
|
|
eventChan = w.Events
|
|
}
|
|
|
|
var certDomain string
|
|
var prevServeConfig *ipn.ServeConfig
|
|
var cm *certs.CertManager
|
|
if cfg.CertShareMode == "rw" {
|
|
cm = certs.NewCertManager(klc.New(lc), log.Printf)
|
|
}
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
case <-cdChanged:
|
|
certDomain = *certDomainAtomic.Load()
|
|
case <-tickChan:
|
|
case <-eventChan:
|
|
// We can't do any reasonable filtering on the event because of how
|
|
// k8s handles these mounts. So just re-read the file and apply it
|
|
// if it's changed.
|
|
}
|
|
sc, err := readServeConfig(cfg.ServeConfigPath, certDomain)
|
|
if err != nil {
|
|
log.Fatalf("serve proxy: failed to read serve config: %v", err)
|
|
}
|
|
if sc == nil {
|
|
log.Printf("serve proxy: no serve config at %q, skipping", cfg.ServeConfigPath)
|
|
continue
|
|
}
|
|
if prevServeConfig != nil && reflect.DeepEqual(sc, prevServeConfig) {
|
|
continue
|
|
}
|
|
if err := updateServeConfig(ctx, sc, certDomain, lc); err != nil {
|
|
log.Fatalf("serve proxy: error updating serve config: %v", err)
|
|
}
|
|
if kc != nil && kc.canPatch {
|
|
if err := kc.storeHTTPSEndpoint(ctx, certDomain); err != nil {
|
|
log.Fatalf("serve proxy: error storing HTTPS endpoint: %v", err)
|
|
}
|
|
}
|
|
prevServeConfig = sc
|
|
if cfg.CertShareMode != "rw" {
|
|
continue
|
|
}
|
|
if err := cm.EnsureCertLoops(ctx, sc); err != nil {
|
|
log.Fatalf("serve proxy: error ensuring cert loops: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func certDomainFromNetmap(nm *netmap.NetworkMap) string {
|
|
if len(nm.DNS.CertDomains) == 0 {
|
|
return ""
|
|
}
|
|
return nm.DNS.CertDomains[0]
|
|
}
|
|
|
|
// localClient is a subset of [local.Client] that can be mocked for testing.
|
|
type localClient interface {
|
|
SetServeConfig(context.Context, *ipn.ServeConfig) error
|
|
CertPair(context.Context, string) ([]byte, []byte, error)
|
|
}
|
|
|
|
func updateServeConfig(ctx context.Context, sc *ipn.ServeConfig, certDomain string, lc localClient) error {
|
|
if !isValidHTTPSConfig(certDomain, sc) {
|
|
return nil
|
|
}
|
|
log.Printf("serve proxy: applying serve config")
|
|
return lc.SetServeConfig(ctx, sc)
|
|
}
|
|
|
|
func isValidHTTPSConfig(certDomain string, sc *ipn.ServeConfig) bool {
|
|
if certDomain == kubetypes.ValueNoHTTPS && hasHTTPSEndpoint(sc) {
|
|
log.Printf(
|
|
`serve proxy: this node is configured as a proxy that exposes an HTTPS endpoint to tailnet,
|
|
(perhaps a Kubernetes operator Ingress proxy) but it is not able to issue TLS certs, so this will likely not work.
|
|
To make it work, ensure that HTTPS is enabled for your tailnet, see https://tailscale.com/kb/1153/enabling-https for more details.`)
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
func hasHTTPSEndpoint(cfg *ipn.ServeConfig) bool {
|
|
if cfg == nil {
|
|
return false
|
|
}
|
|
for _, tcpCfg := range cfg.TCP {
|
|
if tcpCfg.HTTPS {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// readServeConfig reads the ipn.ServeConfig from path, replacing
|
|
// ${TS_CERT_DOMAIN} with certDomain.
|
|
func readServeConfig(path, certDomain string) (*ipn.ServeConfig, error) {
|
|
if path == "" {
|
|
return nil, nil
|
|
}
|
|
j, err := os.ReadFile(path)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
// Serve config can be provided by users as well as the Kubernetes Operator (for its proxies). User-provided
|
|
// config could be empty for reasons.
|
|
if len(j) == 0 {
|
|
log.Printf("serve proxy: serve config file is empty, skipping")
|
|
return nil, nil
|
|
}
|
|
j = bytes.ReplaceAll(j, []byte("${TS_CERT_DOMAIN}"), []byte(certDomain))
|
|
var sc ipn.ServeConfig
|
|
if err := json.Unmarshal(j, &sc); err != nil {
|
|
return nil, err
|
|
}
|
|
return &sc, nil
|
|
}
|