mirror of
https://github.com/tailscale/tailscale.git
synced 2026-05-06 04:36:15 +02:00
0e10a3f580
Add a tsdial.Dialer.UserDialPlan method that resolves an address and reports whether the dialer would route it via Tailscale. The LocalAPI /dial handler now uses this to skip proxying for addresses that aren't Tailscale routes (e.g. localhost), returning a Dial-Self response with the resolved address so the client can dial it directly. This avoids an unnecessary round-trip through the daemon for local connections. The client's UserDial handles the new response by dialing the resolved address itself, and the server passes the pre-resolved IP:port for Tailscale dials to avoid redundant DNS lookups. Thanks to giacomo and Moyao for pointing this out! Updates tailscale/corp#39702 Change-Id: I78d640f11ccd92f43ddd505cbb0db8fee19f43a6 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
98 lines
2.4 KiB
Go
98 lines
2.4 KiB
Go
// Copyright (c) Tailscale Inc & contributors
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package tsdial
|
|
|
|
import (
|
|
"context"
|
|
"net/netip"
|
|
"testing"
|
|
|
|
"github.com/gaissmai/bart"
|
|
)
|
|
|
|
func TestUserDialPlan(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
addr string
|
|
routes map[netip.Prefix]bool // nil means no routes configured
|
|
useNetstackFor func(netip.Addr) bool // nil means not set
|
|
wantVia bool
|
|
wantAddr netip.AddrPort
|
|
}{
|
|
{
|
|
name: "loopback_no_routes",
|
|
addr: "127.0.0.1:8080",
|
|
wantVia: false,
|
|
wantAddr: netip.MustParseAddrPort("127.0.0.1:8080"),
|
|
},
|
|
{
|
|
name: "loopback_v6_no_routes",
|
|
addr: "[::1]:8080",
|
|
wantVia: false,
|
|
wantAddr: netip.MustParseAddrPort("[::1]:8080"),
|
|
},
|
|
{
|
|
name: "tailscale_ip_in_routes",
|
|
addr: "100.64.1.1:22",
|
|
routes: map[netip.Prefix]bool{
|
|
netip.MustParsePrefix("100.64.0.0/10"): true,
|
|
},
|
|
wantVia: true,
|
|
wantAddr: netip.MustParseAddrPort("100.64.1.1:22"),
|
|
},
|
|
{
|
|
name: "non_tailscale_ip_in_local_routes",
|
|
addr: "10.0.0.5:80",
|
|
routes: map[netip.Prefix]bool{
|
|
netip.MustParsePrefix("100.64.0.0/10"): true,
|
|
netip.MustParsePrefix("10.0.0.0/8"): false, // local route
|
|
},
|
|
wantVia: false,
|
|
wantAddr: netip.MustParseAddrPort("10.0.0.5:80"),
|
|
},
|
|
{
|
|
name: "loopback_with_routes_configured",
|
|
addr: "127.0.0.1:3000",
|
|
routes: map[netip.Prefix]bool{
|
|
netip.MustParsePrefix("100.64.0.0/10"): true,
|
|
},
|
|
wantVia: false,
|
|
wantAddr: netip.MustParseAddrPort("127.0.0.1:3000"),
|
|
},
|
|
{
|
|
name: "netstack_for_ip",
|
|
addr: "100.100.100.100:53",
|
|
useNetstackFor: func(ip netip.Addr) bool {
|
|
return ip == netip.MustParseAddr("100.100.100.100")
|
|
},
|
|
wantVia: true,
|
|
wantAddr: netip.MustParseAddrPort("100.100.100.100:53"),
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
d := &Dialer{}
|
|
if tt.routes != nil {
|
|
rt := &bart.Table[bool]{}
|
|
for pfx, v := range tt.routes {
|
|
rt.Insert(pfx, v)
|
|
}
|
|
d.routes.Store(rt)
|
|
}
|
|
d.UseNetstackForIP = tt.useNetstackFor
|
|
|
|
ipp, viaTailscale, err := d.UserDialPlan(context.Background(), "tcp", tt.addr)
|
|
if err != nil {
|
|
t.Fatalf("UserDialPlan: %v", err)
|
|
}
|
|
if viaTailscale != tt.wantVia {
|
|
t.Errorf("viaTailscale = %v, want %v", viaTailscale, tt.wantVia)
|
|
}
|
|
if ipp != tt.wantAddr {
|
|
t.Errorf("addr = %v, want %v", ipp, tt.wantAddr)
|
|
}
|
|
})
|
|
}
|
|
}
|