mirrors/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-05-05 20:26:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

health: fix TestControlHealthNotifies on release branches

Browse Source 
Currently, TestControlHealthNotifies expects three initial health-change
events, including is-using-unstable-version, regardless of whether tests run
on an unstable or release branch.

This change makes the is-using-unstable-version check conditional.

Fixes #17635

Signed-off-by: Nick Khyl <nickk@tailscale.com>
This commit is contained in:
Nick Khyl 2025-10-24 09:48:05 -05:00
parent 8576a802ca
commit f018a16540
No known key found for this signature in database
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
health/health_test.go
View File

@ -741,11 +741,18 @@ func TestControlHealthNotifies(t *testing.T) {
// Expect events at starup, before doing anything else
synctest.Wait()
if err := eventbustest.ExpectExactly(tw,
initialEvents := []any{
eventbustest.Type[Change](), // warming-up
eventbustest.Type[Change](), // is-using-unstable-version
}
if version.IsUnstableBuild() {
initialEvents = append(initialEvents,
eventbustest.Type[Change](), // is-using-unstable-version
)
}
initialEvents = append(initialEvents,
eventbustest.Type[Change](), // not-in-map-poll
); err != nil {
)
if err := eventbustest.ExpectExactly(tw, initialEvents...); err != nil {
t.Errorf("startup error: %v", err)
}