mirrors/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-05-05 20:26:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

controlclient: make logout a no-op if already logged out

Browse Source 
To prevent subsequent cli logouts from erroring in a loop

Updates #3833

Signed-off-by: Irbe Krumina <irbe@tailscale.com>
This commit is contained in:
Irbe Krumina 2023-07-14 16:27:22 -07:00
parent c19b5bfbc3
commit dc057ff8fa
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
control/controlclient/auto.go
View File

@ -694,9 +694,18 @@ func (c *Auto) StartLogout() {
func (c *Auto) Logout(ctx context.Context) error {
c.logf("client.Logout()")
c.mu.Lock()
// This happens if a user logs out when tailscale client is already logged
// out either because the user logged out previously or hasn't yet logged
// in.
if !c.loggedIn {
c.logf("client.Logout(): no action taken, client is already logged out.")
c.mu.Unlock()
return nil
}
errc := make(chan error, 1)
c.mu.Lock()
c.loginGoal = &LoginGoal{
wantLoggedIn: false,
loggedOutResult: errc,