mirrors/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-05-05 04:06:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

util/httpm: open .git/index to defeat Go test caching

Browse Source 
TestUsedConsistently shells out to git grep to find forbidden
http.Method* uses across the repo. Since the test itself doesn't
open any repo files, Go's test cache considers it unchanged
between commits and serves stale passing results even when new
violations are introduced.

Fix by opening .git/index, which makes Go's test cache track it
as an input. The index file changes on git reset, checkout, pull,
etc., so the cache is properly invalidated when moving between
commits.

Updates tailscale/corp#40359

Change-Id: If1497b992a545351bdd68cff279d60f5591fe70b
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2026-04-15 22:37:59 +00:00 committed by Brad Fitzpatrick
parent eea39eaf52
commit b39ee0445d
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
util/httpm/httpm_test.go
View File

@ -24,6 +24,13 @@ func TestUsedConsistently(t *testing.T) {
t.Skipf("skipping test since .git doesn't exist: %v", err)
}
// Open .git/index so Go's test cache tracks it as an input.
// The index file changes on git reset, checkout, pull, etc.,
// so the cache is properly invalidated when moving between commits.
if f, err := os.Open(filepath.Join(rootDir, ".git", "index")); err == nil {
f.Close()
}
cmd := exec.Command("git", "grep", "-l", "-F", "http.Method")
cmd.Dir = rootDir
matches, _ := cmd.Output()