From 9827e6965acedb99fc06f9867290e17bb09ff7e4 Mon Sep 17 00:00:00 2001 From: Andrew Lytvynov Date: Thu, 19 Oct 2023 13:53:44 -0700 Subject: [PATCH] ipn/ipnlocal: send ClientVersion in initial WatchNotifications message If ClientVersion was populated before WatchNotifications started, it would never get delivered to the caller. Explicitly include it. Signed-off-by: Andrew Lytvynov --- ipn/ipnlocal/local.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ipn/ipnlocal/local.go b/ipn/ipnlocal/local.go index 96bb69a6f..4ace95b0d 100644 --- a/ipn/ipnlocal/local.go +++ b/ipn/ipnlocal/local.go @@ -2117,8 +2117,12 @@ func (b *LocalBackend) WatchNotifications(ctx context.Context, mask ipn.NotifyWa ini.BrowseToURL = ptr.To(b.authURLSticky) } } + prefs := b.sanitizedPrefsLocked() if mask&ipn.NotifyInitialPrefs != 0 { - ini.Prefs = ptr.To(b.sanitizedPrefsLocked()) + ini.Prefs = ptr.To(prefs) + } + if prefs.Valid() && prefs.AutoUpdate().Check { + ini.ClientVersion = b.lastClientVersion } if mask&ipn.NotifyInitialNetMap != 0 { ini.NetMap = b.netMap