mirrors/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-05-12 15:56:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

tstest/natlab/vmtest: use short paths for Unix sockets

Browse Source 
macOS limits Unix socket paths to 104 bytes. The Go test TempDir
path (e.g. /var/folders/.../TestDirectConnection...679197086/001/)
easily exceeds that, causing "bind: invalid argument". Create a
short /tmp/vmtest* directory for all socket files (vnet, QMP,
dgram) so the paths stay well under the limit on every platform.

Updates #13038

Change-Id: I721d24561d1766aaa964692bc77f40a131aa9455
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2026-05-11 20:46:18 -07:00 committed by Brad Fitzpatrick
parent f4c5613156
commit 758ebe9839
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tstest/natlab/vmtest/qemu.go
View File

@ -162,7 +162,7 @@ func (e *Env) startCloudQEMU(n *Node) error {
}
logPath := filepath.Join(e.tempDir, n.name+".log")
qmpSock := filepath.Join(e.tempDir, n.name+"-qmp.sock")
qmpSock := filepath.Join(e.sockDir, n.name+"-qmp.sock")
args := []string{
"-machine", "q35",

17
tstest/natlab/vmtest/vmtest.go
View File

@ -66,6 +66,7 @@ type Env struct {
nodes []*Node
tempDir string
sockDir string // short-path dir for Unix sockets (macOS has 104-byte limit)
sockAddr string // shared Unix socket path for all QEMU netdevs
dgramSockAddr string // Unix dgram socket path for macOS VMs (tailmac)
binDir string // directory for compiled binaries
@ -310,9 +311,20 @@ func New(t testing.TB, opts ...EnvOption) *Env {
}
tempDir := t.TempDir()
// Unix sockets have a short path limit (104 bytes on macOS). The Go
// test TempDir path easily exceeds that, so create a dedicated short
// directory under /tmp for sockets.
sockDir, err := os.MkdirTemp("", "vmtest")
if err != nil {
t.Fatalf("creating socket tempdir: %v", err)
}
t.Cleanup(func() { os.RemoveAll(sockDir) })
e := &Env{
t: t,
tempDir: tempDir,
sockDir: sockDir,
binDir: filepath.Join(tempDir, "bin"),
eventBus: newEventBus(),
testStatus: newTestStatus(),
@ -1295,7 +1307,7 @@ func (e *Env) initVnet() {
func (e *Env) ensureQEMUSocket() {
e.qemuSockOnce.Do(func() {
e.initVnet()
e.sockAddr = filepath.Join(e.tempDir, "vnet.sock")
e.sockAddr = filepath.Join(e.sockDir, "vnet.sock")
srv, err := net.Listen("unix", e.sockAddr)
if err != nil {
e.t.Fatalf("listen unix: %v", err)
@ -1317,8 +1329,7 @@ func (e *Env) ensureQEMUSocket() {
func (e *Env) ensureDgramSocket() {
e.dgramSockOnce.Do(func() {
e.initVnet()
e.dgramSockAddr = fmt.Sprintf("/tmp/vmtest-dgram-%d.sock", os.Getpid())
e.t.Cleanup(func() { os.Remove(e.dgramSockAddr) })
e.dgramSockAddr = filepath.Join(e.sockDir, "dgram.sock")
dgramAddr, err := net.ResolveUnixAddr("unixgram", e.dgramSockAddr)
if err != nil {
e.t.Fatalf("resolve dgram addr: %v", err)