From 56d772bd63e5caf711ec7ffe63967d05e33307df Mon Sep 17 00:00:00 2001
From: Nick Khyl <nickk@tailscale.com>
Date: Wed, 2 Jul 2025 19:16:39 -0500
Subject: [PATCH] ipn/ipnlocal: simplify pickNewAutoExitNode

(*profileManager).CurrentPrefs() is always valid. Additionally, there's no value in cloning
and passing the full ipn.Prefs when editing preferences. Instead, ipn.MaskedPrefs should
only have ExitNodeID set.

Updates tailscale/corp#29969

Signed-off-by: Nick Khyl <nickk@tailscale.com>
---
 ipn/ipnlocal/local.go | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/ipn/ipnlocal/local.go b/ipn/ipnlocal/local.go
index bea5085b7..adc0af5cd 100644
--- a/ipn/ipnlocal/local.go
+++ b/ipn/ipnlocal/local.go
@@ -5835,23 +5835,16 @@ func (b *LocalBackend) pickNewAutoExitNode() {
 	unlock := b.lockAndGetUnlock()
 	defer unlock()
 
-	prefs := b.pm.CurrentPrefs()
-	if !prefs.Valid() {
-		b.logf("[unexpected]: received tailnet exit node ID pref change callback but current prefs are nil")
-		return
-	}
-	prefsClone := prefs.AsStruct()
 	newSuggestion, err := b.suggestExitNodeLocked(nil)
 	if err != nil {
 		b.logf("setAutoExitNodeID: %v", err)
 		return
 	}
-	if prefsClone.ExitNodeID == newSuggestion.ID {
+	if b.pm.CurrentPrefs().ExitNodeID() == newSuggestion.ID {
 		return
 	}
-	prefsClone.ExitNodeID = newSuggestion.ID
 	_, err = b.editPrefsLockedOnEntry(&ipn.MaskedPrefs{
-		Prefs:         *prefsClone,
+		Prefs:         ipn.Prefs{ExitNodeID: newSuggestion.ID},
 		ExitNodeIDSet: true,
 	}, unlock)
 	if err != nil {