From 16bd60f9caff91549b40e470d04b3fdfc2e90c47 Mon Sep 17 00:00:00 2001 From: "M. J. Fromberger" Date: Sat, 23 Aug 2025 08:07:36 -0700 Subject: [PATCH] ipn,tsnet: update AdvertiseTags documentation (#16931) Instead of referring to groups, which is a term of art for a different entity, update the doc comments to more accurately describe what tags are in reference to the policy document. Updates #cleanup Change-Id: Iefff6f84981985f834bae7c6a6c34044f53f2ea2 Signed-off-by: M. J. Fromberger --- ipn/prefs.go | 9 ++++----- tsnet/tsnet.go | 9 ++++----- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/ipn/prefs.go b/ipn/prefs.go index 71a80b182..2eb0ccf0c 100644 --- a/ipn/prefs.go +++ b/ipn/prefs.go @@ -158,11 +158,10 @@ type Prefs struct { // connections. This overrides tailcfg.Hostinfo's ShieldsUp. ShieldsUp bool - // AdvertiseTags specifies groups that this node wants to join, for - // purposes of ACL enforcement. These can be referenced from the ACL - // security policy. Note that advertising a tag doesn't guarantee that - // the control server will allow you to take on the rights for that - // tag. + // AdvertiseTags specifies tags that should be applied to this node, for + // purposes of ACL enforcement. These can be referenced from the ACL policy + // document. Note that advertising a tag on the client doesn't guarantee + // that the control server will allow the node to adopt that tag. AdvertiseTags []string // Hostname is the hostname to use for identifying the node. If diff --git a/tsnet/tsnet.go b/tsnet/tsnet.go index 8f2f7bdcd..4cb977c73 100644 --- a/tsnet/tsnet.go +++ b/tsnet/tsnet.go @@ -124,11 +124,10 @@ type Server struct { // field at zero unless you know what you are doing. Port uint16 - // AdvertiseTags specifies groups that this embedded server wants to join, for - // purposes of ACL enforcement. These can be referenced from the ACL - // security policy. Note that advertising a tag doesn't guarantee that - // the control server will allow you to take on the rights for that - // tag. + // AdvertiseTags specifies tags that should be applied to this node, for + // purposes of ACL enforcement. These can be referenced from the ACL policy + // document. Note that advertising a tag on the client doesn't guarantee + // that the control server will allow the node to adopt that tag. AdvertiseTags []string getCertForTesting func(*tls.ClientHelloInfo) (*tls.Certificate, error)