32 Commits

Author SHA1 Message Date
Philip Jenvey
d32c669b7a
refactor: move syncstorage's Db to async-trait (#1830)
Some checks failed
Glean probe-scraper / glean-probe-scraper (push) Has been cancelled
Closes STOR-144
2025-10-03 14:45:18 -07:00
Philip Jenvey
bcf425c635
refactor: kill r2d2 references, share From<PoolError> 2025-09-23 18:32:54 -07:00
Philip Jenvey
192d64c7c3
feat: switch syncstorage to diesel-async
Closes STOR-364
2025-09-23 18:32:51 -07:00
Philip Jenvey
f2698a4251
feat: switch tokenserver to diesel-async (#1790)
Some checks failed
Glean probe-scraper / glean-probe-scraper (push) Has been cancelled
Closes STOR-326
2025-09-08 13:08:29 -07:00
Philip Jenvey
38b4db401f
refactor: apply &mut self to syncstorage-mysql
Closes STOR-327
2025-09-02 13:50:20 -07:00
Philip Jenvey
38cb38fbd9
refactor: switch syncstorage Db methods to &mut self
Closes STOR-327
2025-09-02 13:50:20 -07:00
Philip Jenvey
44148da7c8
merge master 2025-08-28 17:25:26 -07:00
Tommie Gannert
b9507e36c3
chore: Upgrade Diesel to 2.x.
See https://diesel.rs/guides/migration_guide.html.

- This pulls in mysqlclient-sys >=0.4.0, which allows using libmariadb instead of libmysqlclient.
  That allows using Debian's bundled client library.
  MySQL's APT repository only has packages for AMD64.
- Connections are now passed as mut refs, which requires RefCell/RwLock.
- Embedded migrations had a slight API change.
- put_bso_sync was calling update_collection without its transaction, which now causes a deadlock.
  Updated to write inside its transaction.

Signed-off-by: Tommie Gannert <tommie@gannert.se>
2025-08-28 17:07:15 -07:00
Philip Jenvey
0ca435fb1a
refactor: simplify metric_label to return a &str
Issue STOR-64
2025-04-23 16:01:07 -07:00
Eragon
2ae1ef46df
Rename MySQL error to use a more generic name (#1619)
* style: Rename MysqlError to SqlError as they are generic
* refactor: Don't use legacy numerics contant and methods
* style: Cargo fmt
* style: Keep Mysql specific error in Mysql code

---------

Co-authored-by: JR Conlin <jconlin+git@mozilla.com>
2024-12-04 15:47:12 -08:00
Philip Jenvey
9a97b6ce1a
fix: upgrade to latest deadpool (#1631)
which includes a fix for its incorrect metrics:

https://github.com/bikeshedder/deadpool/issues/92

Closes SYNC-4522
2024-11-21 14:59:40 -08:00
Philip Jenvey
bab5e1fe51
feat: namespace the db error labels (#1625)
Closes SYNC-4464
2024-10-30 13:44:17 -07:00
Philip Jenvey
c535e5ae52
feat: wire MysqlError's ReportableError impl into TokenserverError (#1611)
* feat: wire MysqlError's ReportableError impl into TokenserverError

and quiet Pool errors

Closes SYNC-4424

* kluge: allow(clippy::result_large_err) for TokenserverError

(for now) we can get rid of this in a later refactoring
2024-10-17 14:23:45 -07:00
JR Conlin
1713962c6a
Chore/update 2406 (#1576)
chore: Updates for Jun-2024

* f normalize diesel to 1.4

We're currenlty locked to diesel 1.4 due to some significant changes
in the `diesel_logger` crate and how it expects `Connections` to be
defined.
2024-06-25 13:29:42 -07:00
JR Conlin
771813087c
feat: Add normalized ReportableError to errors (#1559)
* feat: Add normalized ReportableError to errors

We want to do things like add tags and other features to sync errors the
way that we do in other packages. To do so, we're backporting
ReportableError from Autopush to Syncstorage.

This also addresses some clippy fixes required by 1.78

This continues to use the `Taggable` trait, which we may want to
port to autopush.

Closes SYNC-4262
2024-05-20 08:51:58 -07:00
JR Conlin
ab7b4221fd
bug: Allow threadpool size to be set. (#1560)
* bug: Allow threadpool size to be set.

It appears that the replacement for setting ACTIX_THREADPOOL would be to
call `ServiceBuilder.worker_max_blocking_threads()` This PR introduces
the ability to set this value by using the
`worker_max_blocking_threads`configuration variable.

Closes #SYNC-4271
2024-05-16 16:36:41 -07:00
Tarik Eshaq
1b11684648
feat: Puts pyo3 behind feature flag and derives tokens directly in Rust (#1513)
* Removes pyo3 and derives tokens directly in Rust

* Adds tests for JWT verifying

* Adds tests for token generation

* Adds metrics for oauth verify error cases

* Updates jsonwebtoken to not include default features (including pem loading)

* Adds context and logs errors during oauth verify

* Uses ring for cryptographic rng

* Adds back python impl under feature flag

* Uses one cached http client for reqwest
2024-02-12 11:14:15 -05:00
bendk
97985586b4
feat: Upgrading to Actix 4.x (#1514)
* Upgrading to Actix 4.x

Also:
  - actix-http 3.x
  - actix-rt 2.x
  - actix-cors 0.6.x
  - tokio 1.x
  - reqwest 0.11.x
  - deadpool 0.7.x

* Update crates after Actix upgrade

Also cleared out the audit exception list.
2024-01-23 13:59:54 -08:00
JR Conlin
1f9323b7b3
feat: convert dependencies to use workspaces
Update package description and some dependencies to use `workspace`
inheritance.

* Also updates circleci to produce dockerhub image.

Closes #1461
Issue #1362

* f touch to retry circleci

* f try to pre-emptively lock protobuf to the older 2.25.2 version

* f force Cargo.lock to use protobuf 2.25.2, dammit

* f move protobuf pin to syncstorage-spanner

* f revert cargo.lock

* f revert #448

* f update base64 / tickle circleci

* f update cadence (and kick circleci)

* f clippy

* f switch to latest google-cloud-rust

* f update to use google-cloud-rust
2023-08-29 13:57:53 -07:00
Philip Jenvey
80d21e7143
merge master 2023-03-07 12:02:16 -08:00
Philip Jenvey
d700e47349
chore: tag 0.13.6 2023-03-06 17:54:52 -08:00
Philip Jenvey
ecb29025a6
chore: tag 0.13.5 2023-03-03 14:12:59 -08:00
Philip Jenvey
028b8b1fb4
chore: tag 0.13.4 2023-02-24 11:09:52 -08:00
Philip Jenvey
2eecb8caca
chore: tag 0.13.3 2023-02-24 09:19:30 -08:00
Philip Jenvey
fb406a055b
chore: tag 0.13.2 2023-02-06 13:20:15 -08:00
Ethan Donowitz
b5b7e57f93
refactor: add database crates (#1407)
Closes #1277
2023-01-10 16:06:03 -05:00
Ethan Donowitz
e48f948456
chore: tag 0.13.1 (#1448) 2022-12-16 14:07:17 -05:00
Ethan Donowitz
e99c22fcc2
chore: tag 0.13.1 2022-12-16 13:15:37 -05:00
Philip Jenvey
926dd11db3
chore: tag 0.13.0 2022-11-13 23:59:45 -08:00
Ethan Donowitz
929a3144af
feat: report blocking threadpool statistics (#1418)
emit metrics about the number of blocking tasks

Closes #1416
2022-11-13 23:49:55 -08:00
Philip Jenvey
23a3c4ba3a
merge master 2022-11-01 12:55:04 -07:00
Ethan Donowitz
0ae5fd2059
refactor: add settings crates (#1306)
This is a breaking change. This commit separates syncstorage and tokenserver settings into separate structs that are contained by a parent `Settings` struct. This means that any env vars that hold settings specific to syncstorage (e.g. `SYNC_DATABASE_URL`) have been renamed to `SYNC_SYNCSTORAGE__DATABASE_URL`. Any settings that were moved from the top-level `Settings` struct to the lower level, syncstorage-specific struct will now have a `SYNC_SYNCSTORAGE__` prefix instead of a `SYNC_` prefix.

Closes #1276
2022-10-19 17:15:56 -04:00