From 9d799a45d41d1f09589cd01ac4df38decb7a9548 Mon Sep 17 00:00:00 2001
From: Philip Jenvey <pjenvey@underboss.org>
Date: Thu, 11 Sep 2025 00:02:00 -0700
Subject: [PATCH] refactor: move tokenserver's Db to async-trait (#1799)

Closes STOR-142
---
 tokenserver-db/src/error.rs  |   1 -
 tokenserver-db/src/lib.rs    |  12 ---
 tokenserver-db/src/mock.rs   | 108 ++++++++++---------
 tokenserver-db/src/models.rs | 201 +++++++++++++++++++++++------------
 4 files changed, 192 insertions(+), 130 deletions(-)

diff --git a/tokenserver-db/src/error.rs b/tokenserver-db/src/error.rs
index 369d270f..3f010cc5 100644
--- a/tokenserver-db/src/error.rs
+++ b/tokenserver-db/src/error.rs
@@ -7,7 +7,6 @@ use syncserver_db_common::error::SqlError;
 use thiserror::Error;
 use tokenserver_common::TokenserverError;
 
-pub(crate) type DbFuture<'a, T> = syncserver_db_common::DbFuture<'a, T, DbError>;
 pub(crate) type DbResult<T> = Result<T, DbError>;
 
 /// An error type that represents any database-related errors that may occur while processing a
diff --git a/tokenserver-db/src/lib.rs b/tokenserver-db/src/lib.rs
index eb6efae1..53886ac2 100644
--- a/tokenserver-db/src/lib.rs
+++ b/tokenserver-db/src/lib.rs
@@ -13,15 +13,3 @@ pub mod results;
 
 pub use models::{Db, TokenserverDb};
 pub use pool::{DbPool, TokenserverPool};
-
-#[macro_export]
-macro_rules! async_db_method {
-    ($name:ident, $async_name:path, $type:ident) => {
-        async_db_method!($name, $async_name, $type, results::$type);
-    };
-    ($name:ident, $async_name:path, $type:ident, $result:ty) => {
-        fn $name(&mut self, params: params::$type) -> DbFuture<'_, $result, DbError> {
-            Box::pin($async_name(self, params))
-        }
-    };
-}
diff --git a/tokenserver-db/src/mock.rs b/tokenserver-db/src/mock.rs
index 05a8df37..f2489dbe 100644
--- a/tokenserver-db/src/mock.rs
+++ b/tokenserver-db/src/mock.rs
@@ -1,10 +1,9 @@
 #![allow(clippy::new_without_default)]
 
 use async_trait::async_trait;
-use futures::future;
 use syncserver_db_common::{GetPoolState, PoolState};
 
-use super::error::{DbError, DbFuture};
+use super::error::DbError;
 use super::models::Db;
 use super::params;
 use super::pool::DbPool;
@@ -49,112 +48,125 @@ impl MockDb {
     }
 }
 
+#[async_trait(?Send)]
 impl Db for MockDb {
-    fn replace_user(&mut self, _params: params::ReplaceUser) -> DbFuture<'_, results::ReplaceUser> {
-        Box::pin(future::ok(()))
+    async fn replace_user(
+        &mut self,
+        _params: params::ReplaceUser,
+    ) -> Result<results::ReplaceUser, DbError> {
+        Ok(())
     }
 
-    fn replace_users(
+    async fn replace_users(
         &mut self,
         _params: params::ReplaceUsers,
-    ) -> DbFuture<'_, results::ReplaceUsers> {
-        Box::pin(future::ok(()))
+    ) -> Result<results::ReplaceUsers, DbError> {
+        Ok(())
     }
 
-    fn post_user(&mut self, _params: params::PostUser) -> DbFuture<'_, results::PostUser> {
-        Box::pin(future::ok(results::PostUser::default()))
+    async fn post_user(&mut self, _params: params::PostUser) -> Result<results::PostUser, DbError> {
+        Ok(results::PostUser::default())
     }
 
-    fn put_user(&mut self, _params: params::PutUser) -> DbFuture<'_, results::PutUser> {
-        Box::pin(future::ok(()))
+    async fn put_user(&mut self, _params: params::PutUser) -> Result<results::PutUser, DbError> {
+        Ok(())
     }
 
-    fn check(&mut self) -> DbFuture<'_, results::Check> {
-        Box::pin(future::ok(true))
+    async fn check(&mut self) -> Result<results::Check, DbError> {
+        Ok(true)
     }
 
-    fn get_node_id(&mut self, _params: params::GetNodeId) -> DbFuture<'_, results::GetNodeId> {
-        Box::pin(future::ok(results::GetNodeId::default()))
+    async fn get_node_id(
+        &mut self,
+        _params: params::GetNodeId,
+    ) -> Result<results::GetNodeId, DbError> {
+        Ok(results::GetNodeId::default())
     }
 
-    fn get_best_node(
+    async fn get_best_node(
         &mut self,
         _params: params::GetBestNode,
-    ) -> DbFuture<'_, results::GetBestNode> {
-        Box::pin(future::ok(results::GetBestNode::default()))
+    ) -> Result<results::GetBestNode, DbError> {
+        Ok(results::GetBestNode::default())
     }
 
-    fn add_user_to_node(
+    async fn add_user_to_node(
         &mut self,
         _params: params::AddUserToNode,
-    ) -> DbFuture<'_, results::AddUserToNode> {
-        Box::pin(future::ok(()))
+    ) -> Result<results::AddUserToNode, DbError> {
+        Ok(())
     }
 
-    fn get_users(&mut self, _params: params::GetUsers) -> DbFuture<'_, results::GetUsers> {
-        Box::pin(future::ok(results::GetUsers::default()))
+    async fn get_users(&mut self, _params: params::GetUsers) -> Result<results::GetUsers, DbError> {
+        Ok(results::GetUsers::default())
     }
 
-    fn get_or_create_user(
+    async fn get_or_create_user(
         &mut self,
         _params: params::GetOrCreateUser,
-    ) -> DbFuture<'_, results::GetOrCreateUser> {
-        Box::pin(future::ok(results::GetOrCreateUser::default()))
+    ) -> Result<results::GetOrCreateUser, DbError> {
+        Ok(results::GetOrCreateUser::default())
     }
 
-    fn get_service_id(
+    async fn get_service_id(
         &mut self,
         _params: params::GetServiceId,
-    ) -> DbFuture<'_, results::GetServiceId> {
-        Box::pin(future::ok(results::GetServiceId::default()))
+    ) -> Result<results::GetServiceId, DbError> {
+        Ok(results::GetServiceId::default())
     }
 
     #[cfg(test)]
-    fn set_user_created_at(
+    async fn set_user_created_at(
         &mut self,
         _params: params::SetUserCreatedAt,
-    ) -> DbFuture<'_, results::SetUserCreatedAt> {
-        Box::pin(future::ok(()))
+    ) -> Result<results::SetUserCreatedAt, DbError> {
+        Ok(())
     }
 
     #[cfg(test)]
-    fn set_user_replaced_at(
+    async fn set_user_replaced_at(
         &mut self,
         _params: params::SetUserReplacedAt,
-    ) -> DbFuture<'_, results::SetUserReplacedAt> {
-        Box::pin(future::ok(()))
+    ) -> Result<results::SetUserReplacedAt, DbError> {
+        Ok(())
     }
 
     #[cfg(test)]
-    fn get_user(&mut self, _params: params::GetUser) -> DbFuture<'_, results::GetUser> {
-        Box::pin(future::ok(results::GetUser::default()))
+    async fn get_user(&mut self, _params: params::GetUser) -> Result<results::GetUser, DbError> {
+        Ok(results::GetUser::default())
     }
 
     #[cfg(test)]
-    fn post_node(&mut self, _params: params::PostNode) -> DbFuture<'_, results::PostNode> {
-        Box::pin(future::ok(results::PostNode::default()))
+    async fn post_node(&mut self, _params: params::PostNode) -> Result<results::PostNode, DbError> {
+        Ok(results::PostNode::default())
     }
 
     #[cfg(test)]
-    fn get_node(&mut self, _params: params::GetNode) -> DbFuture<'_, results::GetNode> {
-        Box::pin(future::ok(results::GetNode::default()))
+    async fn get_node(&mut self, _params: params::GetNode) -> Result<results::GetNode, DbError> {
+        Ok(results::GetNode::default())
     }
 
     #[cfg(test)]
-    fn unassign_node(
+    async fn unassign_node(
         &mut self,
         _params: params::UnassignNode,
-    ) -> DbFuture<'_, results::UnassignNode> {
-        Box::pin(future::ok(()))
+    ) -> Result<results::UnassignNode, DbError> {
+        Ok(())
     }
 
     #[cfg(test)]
-    fn remove_node(&mut self, _params: params::RemoveNode) -> DbFuture<'_, results::RemoveNode> {
-        Box::pin(future::ok(()))
+    async fn remove_node(
+        &mut self,
+        _params: params::RemoveNode,
+    ) -> Result<results::RemoveNode, DbError> {
+        Ok(())
     }
 
     #[cfg(test)]
-    fn post_service(&mut self, _params: params::PostService) -> DbFuture<'_, results::PostService> {
-        Box::pin(future::ok(results::PostService::default()))
+    async fn post_service(
+        &mut self,
+        _params: params::PostService,
+    ) -> Result<results::PostService, DbError> {
+        Ok(results::PostService::default())
     }
 }
diff --git a/tokenserver-db/src/models.rs b/tokenserver-db/src/models.rs
index afe30fd0..707293db 100644
--- a/tokenserver-db/src/models.rs
+++ b/tokenserver-db/src/models.rs
@@ -1,3 +1,4 @@
+use async_trait::async_trait;
 use diesel::{
     sql_types::{Bigint, Float, Integer, Nullable, Text},
     OptionalExtension,
@@ -5,12 +6,10 @@ use diesel::{
 use diesel_async::RunQueryDsl;
 use http::StatusCode;
 use syncserver_common::Metrics;
-use syncserver_db_common::DbFuture;
 
 use std::time::{Duration, SystemTime, UNIX_EPOCH};
 
 use super::{
-    async_db_method,
     error::{DbError, DbResult},
     params,
     pool::Conn,
@@ -685,156 +684,220 @@ impl TokenserverDb {
     }
 }
 
+#[async_trait(?Send)]
 impl Db for TokenserverDb {
-    async_db_method!(replace_user, TokenserverDb::replace_user, ReplaceUser);
-    async_db_method!(replace_users, TokenserverDb::replace_users, ReplaceUsers);
-    async_db_method!(post_user, TokenserverDb::post_user, PostUser);
+    async fn replace_user(
+        &mut self,
+        params: params::ReplaceUser,
+    ) -> Result<results::ReplaceUser, DbError> {
+        TokenserverDb::replace_user(self, params).await
+    }
 
-    async_db_method!(put_user, TokenserverDb::put_user, PutUser);
+    async fn replace_users(
+        &mut self,
+        params: params::ReplaceUsers,
+    ) -> Result<results::ReplaceUsers, DbError> {
+        TokenserverDb::replace_users(self, params).await
+    }
 
-    async_db_method!(get_node_id, TokenserverDb::get_node_id, GetNodeId);
+    async fn post_user(&mut self, params: params::PostUser) -> Result<results::PostUser, DbError> {
+        TokenserverDb::post_user(self, params).await
+    }
 
-    async_db_method!(get_best_node, TokenserverDb::get_best_node, GetBestNode);
-    async_db_method!(
-        add_user_to_node,
-        TokenserverDb::add_user_to_node,
-        AddUserToNode
-    );
-    async_db_method!(get_users, TokenserverDb::get_users, GetUsers);
-    async_db_method!(
-        get_or_create_user,
-        TokenserverDb::get_or_create_user,
-        GetOrCreateUser
-    );
-    async_db_method!(get_service_id, TokenserverDb::get_service_id, GetServiceId);
+    async fn put_user(&mut self, params: params::PutUser) -> Result<results::PutUser, DbError> {
+        TokenserverDb::put_user(self, params).await
+    }
+
+    async fn get_node_id(
+        &mut self,
+        params: params::GetNodeId,
+    ) -> Result<results::GetNodeId, DbError> {
+        TokenserverDb::get_node_id(self, params).await
+    }
+
+    async fn get_best_node(
+        &mut self,
+        params: params::GetBestNode,
+    ) -> Result<results::GetBestNode, DbError> {
+        TokenserverDb::get_best_node(self, params).await
+    }
+
+    async fn add_user_to_node(
+        &mut self,
+        params: params::AddUserToNode,
+    ) -> Result<results::AddUserToNode, DbError> {
+        TokenserverDb::add_user_to_node(self, params).await
+    }
+
+    async fn get_users(&mut self, params: params::GetUsers) -> Result<results::GetUsers, DbError> {
+        TokenserverDb::get_users(self, params).await
+    }
+
+    async fn get_or_create_user(
+        &mut self,
+        params: params::GetOrCreateUser,
+    ) -> Result<results::GetOrCreateUser, DbError> {
+        TokenserverDb::get_or_create_user(self, params).await
+    }
+
+    async fn get_service_id(
+        &mut self,
+        params: params::GetServiceId,
+    ) -> Result<results::GetServiceId, DbError> {
+        TokenserverDb::get_service_id(self, params).await
+    }
 
     fn timeout(&self) -> Option<Duration> {
         self.timeout
     }
 
     #[cfg(test)]
-    async_db_method!(get_user, TokenserverDb::get_user, GetUser);
+    async fn get_user(&mut self, params: params::GetUser) -> Result<results::GetUser, DbError> {
+        TokenserverDb::get_user(self, params).await
+    }
 
-    fn check(&mut self) -> DbFuture<'_, results::Check, DbError> {
-        Box::pin(TokenserverDb::check(self))
+    async fn check(&mut self) -> Result<results::Check, DbError> {
+        TokenserverDb::check(self).await
     }
 
     #[cfg(test)]
-    async_db_method!(
-        set_user_created_at,
-        TokenserverDb::set_user_created_at,
-        SetUserCreatedAt
-    );
+    async fn set_user_created_at(
+        &mut self,
+        params: params::SetUserCreatedAt,
+    ) -> Result<results::SetUserCreatedAt, DbError> {
+        TokenserverDb::set_user_created_at(self, params).await
+    }
 
     #[cfg(test)]
-    async_db_method!(
-        set_user_replaced_at,
-        TokenserverDb::set_user_replaced_at,
-        SetUserReplacedAt
-    );
+    async fn set_user_replaced_at(
+        &mut self,
+        params: params::SetUserReplacedAt,
+    ) -> Result<results::SetUserReplacedAt, DbError> {
+        TokenserverDb::set_user_replaced_at(self, params).await
+    }
 
     #[cfg(test)]
-    async_db_method!(post_node, TokenserverDb::post_node, PostNode);
+    async fn post_node(&mut self, params: params::PostNode) -> Result<results::PostNode, DbError> {
+        TokenserverDb::post_node(self, params).await
+    }
 
     #[cfg(test)]
-    async_db_method!(get_node, TokenserverDb::get_node, GetNode);
+    async fn get_node(&mut self, params: params::GetNode) -> Result<results::GetNode, DbError> {
+        TokenserverDb::get_node(self, params).await
+    }
 
     #[cfg(test)]
-    async_db_method!(unassign_node, TokenserverDb::unassign_node, UnassignNode);
+    async fn unassign_node(
+        &mut self,
+        params: params::UnassignNode,
+    ) -> Result<results::UnassignNode, DbError> {
+        TokenserverDb::unassign_node(self, params).await
+    }
 
     #[cfg(test)]
-    async_db_method!(remove_node, TokenserverDb::remove_node, RemoveNode);
+    async fn remove_node(
+        &mut self,
+        params: params::RemoveNode,
+    ) -> Result<results::RemoveNode, DbError> {
+        TokenserverDb::remove_node(self, params).await
+    }
 
     #[cfg(test)]
-    async_db_method!(post_service, TokenserverDb::post_service, PostService);
+    async fn post_service(
+        &mut self,
+        params: params::PostService,
+    ) -> Result<results::PostService, DbError> {
+        TokenserverDb::post_service(self, params).await
+    }
 }
 
+#[async_trait(?Send)]
 pub trait Db {
     fn timeout(&self) -> Option<Duration> {
         None
     }
 
-    fn replace_user(
+    async fn replace_user(
         &mut self,
         params: params::ReplaceUser,
-    ) -> DbFuture<'_, results::ReplaceUser, DbError>;
+    ) -> Result<results::ReplaceUser, DbError>;
 
-    fn replace_users(
+    async fn replace_users(
         &mut self,
         params: params::ReplaceUsers,
-    ) -> DbFuture<'_, results::ReplaceUsers, DbError>;
+    ) -> Result<results::ReplaceUsers, DbError>;
 
-    fn post_user(&mut self, params: params::PostUser) -> DbFuture<'_, results::PostUser, DbError>;
+    async fn post_user(&mut self, params: params::PostUser) -> Result<results::PostUser, DbError>;
 
-    fn put_user(&mut self, params: params::PutUser) -> DbFuture<'_, results::PutUser, DbError>;
+    async fn put_user(&mut self, params: params::PutUser) -> Result<results::PutUser, DbError>;
 
-    fn check(&mut self) -> DbFuture<'_, results::Check, DbError>;
+    async fn check(&mut self) -> Result<results::Check, DbError>;
 
-    fn get_node_id(
+    async fn get_node_id(
         &mut self,
         params: params::GetNodeId,
-    ) -> DbFuture<'_, results::GetNodeId, DbError>;
+    ) -> Result<results::GetNodeId, DbError>;
 
-    fn get_best_node(
+    async fn get_best_node(
         &mut self,
         params: params::GetBestNode,
-    ) -> DbFuture<'_, results::GetBestNode, DbError>;
+    ) -> Result<results::GetBestNode, DbError>;
 
-    fn add_user_to_node(
+    async fn add_user_to_node(
         &mut self,
         params: params::AddUserToNode,
-    ) -> DbFuture<'_, results::AddUserToNode, DbError>;
+    ) -> Result<results::AddUserToNode, DbError>;
 
-    fn get_users(&mut self, params: params::GetUsers) -> DbFuture<'_, results::GetUsers, DbError>;
+    async fn get_users(&mut self, params: params::GetUsers) -> Result<results::GetUsers, DbError>;
 
-    fn get_or_create_user(
+    async fn get_or_create_user(
         &mut self,
         params: params::GetOrCreateUser,
-    ) -> DbFuture<'_, results::GetOrCreateUser, DbError>;
+    ) -> Result<results::GetOrCreateUser, DbError>;
 
-    fn get_service_id(
+    async fn get_service_id(
         &mut self,
         params: params::GetServiceId,
-    ) -> DbFuture<'_, results::GetServiceId, DbError>;
+    ) -> Result<results::GetServiceId, DbError>;
 
     #[cfg(test)]
-    fn set_user_created_at(
+    async fn set_user_created_at(
         &mut self,
         params: params::SetUserCreatedAt,
-    ) -> DbFuture<'_, results::SetUserCreatedAt, DbError>;
+    ) -> Result<results::SetUserCreatedAt, DbError>;
 
     #[cfg(test)]
-    fn set_user_replaced_at(
+    async fn set_user_replaced_at(
         &mut self,
         params: params::SetUserReplacedAt,
-    ) -> DbFuture<'_, results::SetUserReplacedAt, DbError>;
+    ) -> Result<results::SetUserReplacedAt, DbError>;
 
     #[cfg(test)]
-    fn get_user(&mut self, params: params::GetUser) -> DbFuture<'_, results::GetUser, DbError>;
+    async fn get_user(&mut self, params: params::GetUser) -> Result<results::GetUser, DbError>;
 
     #[cfg(test)]
-    fn post_node(&mut self, params: params::PostNode) -> DbFuture<'_, results::PostNode, DbError>;
+    async fn post_node(&mut self, params: params::PostNode) -> Result<results::PostNode, DbError>;
 
     #[cfg(test)]
-    fn get_node(&mut self, params: params::GetNode) -> DbFuture<'_, results::GetNode, DbError>;
+    async fn get_node(&mut self, params: params::GetNode) -> Result<results::GetNode, DbError>;
 
     #[cfg(test)]
-    fn unassign_node(
+    async fn unassign_node(
         &mut self,
         params: params::UnassignNode,
-    ) -> DbFuture<'_, results::UnassignNode, DbError>;
+    ) -> Result<results::UnassignNode, DbError>;
 
     #[cfg(test)]
-    fn remove_node(
+    async fn remove_node(
         &mut self,
         params: params::RemoveNode,
-    ) -> DbFuture<'_, results::RemoveNode, DbError>;
+    ) -> Result<results::RemoveNode, DbError>;
 
     #[cfg(test)]
-    fn post_service(
+    async fn post_service(
         &mut self,
         params: params::PostService,
-    ) -> DbFuture<'_, results::PostService, DbError>;
+    ) -> Result<results::PostService, DbError>;
 }
 
 #[cfg(test)]