mirrors/syncstorage-rs
1
0
Fork 0
mirror of https://github.com/mozilla-services/syncstorage-rs.git synced 2026-05-05 04:06:16 +02:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix: avoid underflow of the queued_tasks metric

Browse Source 
Closes STOR-201
This commit is contained in:
Philip Jenvey 2025-04-18 16:29:15 -07:00
parent 31dda13680
commit 10daab06cf
No known key found for this signature in database
GPG Key ID: 5B9F83DE4F7EB7FA
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
syncserver-common/src/lib.rs
View File

@ -155,7 +155,13 @@ impl BlockingThreadpool {
/// Return the pool's current metrics
pub fn metrics(&self) -> BlockingThreadpoolMetrics {
let spawned_tasks = self.spawned_tasks.load(Ordering::Relaxed);
let active_threads = self.active_threads.load(Ordering::Relaxed);
// active_threads is decremented on a separate thread so there's no
// Drop order guarantee of spawned_tasks decrementing before it does:
// catch the case where active_threads is larger
let active_threads = self
.active_threads
.load(Ordering::Relaxed)
.min(spawned_tasks);
BlockingThreadpoolMetrics {
queued_tasks: spawned_tasks - active_threads,
active_threads,