From 0203261ea6967bf5bda7a6284e1c3fc5edcd1238 Mon Sep 17 00:00:00 2001
From: Amrita Gupta <amritagupta727790@gmail.com>
Date: Thu, 19 Mar 2020 18:16:38 +0000
Subject: [PATCH] chore: move `insert into` to the bottom of ddl

There should be a visual separation between `insert into` and `create
table` commands. Also, `insert into`s should be run only after `create
table`s. Let's move `insert into` statements to the bottom to convey
the same.

Closes #473
---
 spanner-2019-10-01.ddl | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/spanner-2019-10-01.ddl b/spanner-2019-10-01.ddl
index 03e6b8c1..ef714016 100644
--- a/spanner-2019-10-01.ddl
+++ b/spanner-2019-10-01.ddl
@@ -48,21 +48,6 @@ CREATE TABLE collections (
     CREATE UNIQUE INDEX CollectionName
         ON collections(name);
 
-INSERT INTO collections (collection_id, name) VALUES
-    ( 1, "clients"),
-    ( 2, "crypto"),
-    ( 3, "forms"),
-    ( 4, "history"),
-    ( 5, "keys"),
-    ( 6, "meta"),
-    ( 7, "bookmarks"),
-    ( 8, "prefs"),
-    ( 9, "tabs"),
-    (10, "passwords"),
-    (11, "addons"),
-    (12, "addresses"),
-    (13, "creditcards");
-
 CREATE TABLE batches (
   fxa_uid STRING(MAX)  NOT NULL,
   fxa_kid STRING(MAX)  NOT NULL,
@@ -92,3 +77,22 @@ CREATE TABLE batch_bsos (
 -- not set each individual field of each item. Also note that there's
 -- no "modified" column because the modification timestamp gets set on
 -- batch commit.
+
+-- 8< Cut Here >8 -- 
+-- Inserting values into table(s) should happen only
+-- after table creation.
+
+INSERT INTO collections (collection_id, name) VALUES
+    ( 1, "clients"),
+    ( 2, "crypto"),
+    ( 3, "forms"),
+    ( 4, "history"),
+    ( 5, "keys"),
+    ( 6, "meta"),
+    ( 7, "bookmarks"),
+    ( 8, "prefs"),
+    ( 9, "tabs"),
+    (10, "passwords"),
+    (11, "addons"),
+    (12, "addresses"),
+    (13, "creditcards");