mirrors/synapse
1
0
Fork 0
mirror of https://github.com/matrix-org/synapse.git synced 2025-10-31 08:11:24 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2809 from matrix-org/rav/metrics_errors

Browse Source 
better exception logging in callbackmetrics
This commit is contained in:
Richard van der Hoff 2018-01-18 11:46:37 +00:00 committed by GitHub
commit d6af5512bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
synapse/metrics/metric.py
View File

@ -15,6 +15,9 @@
from itertools import chain from itertools import chain
import logging
logger = logging.getLogger(__name__)
def flatten(items): def flatten(items):
@ -153,7 +156,11 @@ class CallbackMetric(BaseMetric):
self.callback = callback self.callback = callback
def render(self): def render(self):
value = self.callback() try:
value = self.callback()
except Exception:
logger.exception("Failed to render %s", self.name)
return ["# FAILED to render " + self.name]
if self.is_scalar(): if self.is_scalar():
return list(self._render_for_labels([], value)) return list(self._render_for_labels([], value))