mirror of
				https://github.com/matrix-org/synapse.git
				synced 2025-11-04 02:01:03 +01:00 
			
		
		
		
	better exception logging in callbackmetrics
when we fail to render a metric, give a clue as to which metric it was
This commit is contained in:
		
							parent
							
								
									a87006f9c7
								
							
						
					
					
						commit
						ce236f8ac8
					
				@ -15,6 +15,9 @@
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
from itertools import chain
 | 
			
		||||
import logging
 | 
			
		||||
 | 
			
		||||
logger = logging.getLogger(__name__)
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
def flatten(items):
 | 
			
		||||
@ -153,7 +156,11 @@ class CallbackMetric(BaseMetric):
 | 
			
		||||
        self.callback = callback
 | 
			
		||||
 | 
			
		||||
    def render(self):
 | 
			
		||||
        try:
 | 
			
		||||
            value = self.callback()
 | 
			
		||||
        except Exception:
 | 
			
		||||
            logger.exception("Failed to render %s", self.name)
 | 
			
		||||
            return ["# FAILED to render " + self.name]
 | 
			
		||||
 | 
			
		||||
        if self.is_scalar():
 | 
			
		||||
            return list(self._render_for_labels([], value))
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user