From d3970faeabfc886a4524bc8ce73461f8ab532998 Mon Sep 17 00:00:00 2001 From: Isaku Yamahata Date: Thu, 28 Mar 2013 16:08:11 +0900 Subject: [PATCH] lib/packet/packet_base: fix signature of PacketBase.{parser, serialize} All subclasses define them as parser(cls, buf) and serialize(self, payload, prev) Not parser(cls), serialize(self). pylint also complains like > W: 50,4:ipv4.parser: Arguments number differs from overridden method > W: 65,4:ipv4.serialize: Arguments number differs from overridden method Signed-off-by: Isaku Yamahata Signed-off-by: FUJITA Tomonori --- ryu/lib/packet/packet_base.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index 437678b3..aa38eb03 100644 --- a/ryu/lib/packet/packet_base.py +++ b/ryu/lib/packet/packet_base.py @@ -31,8 +31,8 @@ class PacketBase(object): self.protocol_name = self.__class__.__name__ @classmethod - def parser(cls): + def parser(cls, buf): pass - def serialize(self): + def serialize(self, payload, prev): pass