From 7e30cf6b0136b97823e8a17280d69eb482ca1fa7 Mon Sep 17 00:00:00 2001 From: IWASE Yusuke Date: Fri, 16 Dec 2016 15:17:38 +0900 Subject: [PATCH] rpc_cli: Avoid to use eval() Signed-off-by: IWASE Yusuke Signed-off-by: FUJITA Tomonori --- ryu/cmd/rpc_cli.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ryu/cmd/rpc_cli.py b/ryu/cmd/rpc_cli.py index 2c1eb6b3..25b92fa5 100755 --- a/ryu/cmd/rpc_cli.py +++ b/ryu/cmd/rpc_cli.py @@ -31,6 +31,7 @@ from __future__ import print_function +import ast import cmd import signal import socket @@ -139,9 +140,9 @@ class Cmd(cmd.Cmd): try: peer = args[0] method = args[1] - params = eval(args[2]) - except: - print("argument error") + params = ast.literal_eval(args[2]) + except (IndexError, ValueError) as e: + print("argument error: %s" % e) return try: p = peers[peer]