From 72a5b442b1192c3e94cee9f48df265a95e72ebfe Mon Sep 17 00:00:00 2001 From: IWASE Yusuke Date: Fri, 9 Oct 2015 16:51:25 +0900 Subject: [PATCH] tester: Remove too broad exception handling Because too broad exception handling obscures errors while testing, it makes difficult to detect the bugs in tester.py or the test pattern files. This patch removes an except statement and avoid this problem. Signed-off-by: IWASE Yusuke Signed-off-by: FUJITA Tomonori --- ryu/tests/switch/tester.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/ryu/tests/switch/tester.py b/ryu/tests/switch/tester.py index f5bbd53b..3af7f767 100644 --- a/ryu/tests/switch/tester.py +++ b/ryu/tests/switch/tester.py @@ -529,9 +529,6 @@ class OfTester(app_manager.RyuApp): TestTimeout, TestReceiveError) as err: result = [TEST_ERROR, str(err)] result_type = str(err).split(':', 1)[0] - except Exception: - result = [TEST_ERROR, RYU_INTERNAL_ERROR] - result_type = RYU_INTERNAL_ERROR finally: self.ingress_event = None for tid in self.ingress_threads: