mirror of
https://github.com/prometheus/prometheus.git
synced 2025-10-31 00:11:23 +01:00
c3c7d44d84
We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>
48 lines
1.2 KiB
Go
48 lines
1.2 KiB
Go
// Copyright 2019 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package logging
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type counter int
|
|
|
|
func (c *counter) Log(...interface{}) error {
|
|
(*c)++
|
|
return nil
|
|
}
|
|
|
|
func TestDedupe(t *testing.T) {
|
|
var c counter
|
|
d := Dedupe(&c, 100*time.Millisecond)
|
|
defer d.Stop()
|
|
|
|
// Log 10 times quickly, ensure they are deduped.
|
|
for i := 0; i < 10; i++ {
|
|
err := d.Log("msg", "hello")
|
|
require.NoError(t, err)
|
|
}
|
|
require.Equal(t, 1, int(c))
|
|
|
|
// Wait, then log again, make sure it is logged.
|
|
time.Sleep(200 * time.Millisecond)
|
|
err := d.Log("msg", "hello")
|
|
require.NoError(t, err)
|
|
require.Equal(t, 2, int(c))
|
|
}
|