Callum Styan c453def8c5

Separate scrape add error checking out into it's own function. (#6930) ...

* Separate scrape add error checking out into it's own function.

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* pass sampleLimitError to checkAddError instead of returning an error

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* Return bool, error from checkAddError so we can properly handle
ErrNotFound for AddFast. This should in theory never happen, but the
previous code path handled this case. Adds a test for this, which master
passes and the previous commit fails.

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* Address comment changes.

Signed-off-by: Callum Styan <callumstyan@gmail.com>

* Move sampleAdded inside the loop iteration within append, since that's
the only block the variable is used in.

Signed-off-by: Callum Styan <callumstyan@gmail.com>

2020-03-25 19:31:48 -07:00

..

testdata

rename package retrieve to scrape

2018-02-01 09:55:07 +00:00

helpers_test.go

Unify Iterator interfaces. All point to storage now.

2020-02-17 18:03:54 +00:00

manager_test.go

Improve testutil.ErrorEqual (#6471)

2019-12-17 21:11:33 +00:00

manager.go

Unify Iterator interfaces. All point to storage now.

2020-02-17 18:03:54 +00:00

scrape_test.go

Separate scrape add error checking out into it's own function. (#6930)

2020-03-25 19:31:48 -07:00

scrape.go

Separate scrape add error checking out into it's own function. (#6930)

2020-03-25 19:31:48 -07:00

target_test.go

Update go.mod dependencies before release (#5883)

2019-08-14 11:00:39 +02:00

target.go

Unify Iterator interfaces. All point to storage now.

2020-02-17 18:03:54 +00:00