mirror of
https://github.com/prometheus/prometheus.git
synced 2025-08-05 21:57:09 +02:00
c5b92f71d4
* Fix storage/remote.pool interned refs count and flaky test I saw TestIntern_MultiRef_Concurrent failing on a different PR saying 'expected refs to be 1 but it was 2'. I took a look, and it definitely can be racy, especially with a time.Sleep() of just 1ms. I'm fixing that by explicitly waiting until it has been released, and by repeating that 1000 times, otherwise it's just a recipe for a future flaky test. OTOH, I also took a look at the implementation and saw that we were not holding the RLock() when increasing the references count, so when releasing there was a race condition for the cleanup, I fixed that by holding RLock() while increasing the references count. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * s/Equalf/Equal/ Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
94 lines
2.7 KiB
Go
94 lines
2.7 KiB
Go
// Copyright 2019 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
// Inspired / copied / modified from https://gitlab.com/cznic/strutil/blob/master/strutil.go,
|
|
// which is MIT licensed, so:
|
|
//
|
|
// Copyright (c) 2014 The strutil Authors. All rights reserved.
|
|
|
|
package remote
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestIntern(t *testing.T) {
|
|
interner := newPool()
|
|
testString := "TestIntern"
|
|
interner.intern(testString)
|
|
interned, ok := interner.pool[testString]
|
|
|
|
require.True(t, ok)
|
|
require.Equalf(t, int64(1), interned.refs.Load(), "expected refs to be 1 but it was %d", interned.refs.Load())
|
|
}
|
|
|
|
func TestIntern_MultiRef(t *testing.T) {
|
|
interner := newPool()
|
|
testString := "TestIntern_MultiRef"
|
|
|
|
interner.intern(testString)
|
|
interned, ok := interner.pool[testString]
|
|
|
|
require.True(t, ok)
|
|
require.Equalf(t, int64(1), interned.refs.Load(), "expected refs to be 1 but it was %d", interned.refs.Load())
|
|
|
|
interner.intern(testString)
|
|
interned, ok = interner.pool[testString]
|
|
|
|
require.True(t, ok)
|
|
require.Equalf(t, int64(2), interned.refs.Load(), "expected refs to be 2 but it was %d", interned.refs.Load())
|
|
}
|
|
|
|
func TestIntern_DeleteRef(t *testing.T) {
|
|
interner := newPool()
|
|
testString := "TestIntern_DeleteRef"
|
|
|
|
interner.intern(testString)
|
|
interned, ok := interner.pool[testString]
|
|
|
|
require.True(t, ok)
|
|
require.Equalf(t, int64(1), interned.refs.Load(), "expected refs to be 1 but it was %d", interned.refs.Load())
|
|
|
|
interner.release(testString)
|
|
_, ok = interner.pool[testString]
|
|
require.False(t, ok)
|
|
}
|
|
|
|
func TestIntern_MultiRef_Concurrent(t *testing.T) {
|
|
interner := newPool()
|
|
testString := "TestIntern_MultiRef_Concurrent"
|
|
|
|
interner.intern(testString)
|
|
interned, ok := interner.pool[testString]
|
|
require.True(t, ok)
|
|
require.Equal(t, int64(1), interned.refs.Load(), "wrong interned refs count")
|
|
|
|
for i := 0; i < 1000; i++ {
|
|
released := make(chan struct{})
|
|
go func() {
|
|
interner.release(testString)
|
|
close(released)
|
|
}()
|
|
interner.intern(testString)
|
|
<-released
|
|
}
|
|
|
|
interner.mtx.RLock()
|
|
interned, ok = interner.pool[testString]
|
|
interner.mtx.RUnlock()
|
|
require.True(t, ok)
|
|
require.Equal(t, int64(1), interned.refs.Load(), "wrong interned refs count")
|
|
}
|