prometheus

mirror of https://github.com/prometheus/prometheus.git synced 2026-02-13 11:51:03 +01:00

History

fix(notify): apply config sendloop cleanup fix (#17915 )

These bugs were discovered accidentally with code analysis:
- https://app.devin.ai/review/prometheus/prometheus/pull/16355

Upon further inspection and performing more analysis, 3 potential bugs were found:
1. sendloops could continue running if corresponding AM changed position in the config
2. multiple configs with the same hash would share sendloops resulting in sets without sendloops
3. sendloops could continue running if the config hash was changed

- `TestApplyConfigSendLoopsNotStoppedOnKeyChange`: Verifies sendLoops work when keys swap (no fix needed)
- `TestApplyConfigDuplicateHashSharesSendLoops`: Verifies sendLoops are independent with duplicate hashes (bug fixed)
- `TestApplyConfigHashChangeLeaksSendLoops`: Verifies sendLoops are cleaned up when hash changes (bug fixed)

Signed-off-by: Siavash Safi <siavash@cloudflare.com>

2026-01-22 22:22:44 +01:00

alert.go

Remove copyright date from headers (#17785 )

2026-01-05 13:46:21 +01:00

alertmanager_test.go

feat(notifier): independent alertmanager sendloops (#16355 )

2026-01-20 10:33:07 +01:00

alertmanager.go

Remove copyright date from headers (#17785 )

2026-01-05 13:46:21 +01:00

alertmanagerset.go

feat(notifier): independent alertmanager sendloops (#16355 )