mirror of
https://github.com/prometheus/prometheus.git
synced 2025-09-21 13:51:00 +02:00
Currently the API always returns http code 422 for engine execution error, and This PR allows the error code to be overriden, based on the ErrorType and the error itself. Signed-off-by: Justin Jung <jungjust@amazon.com> Signed-off-by: Justin Jung <justinjung04@gmail.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
288 lines
8.1 KiB
Go
288 lines
8.1 KiB
Go
// Copyright 2022 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package v1
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/grafana/regexp"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/prometheus/common/promslog"
|
|
"github.com/prometheus/common/route"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/prometheus/prometheus/config"
|
|
"github.com/prometheus/prometheus/model/labels"
|
|
"github.com/prometheus/prometheus/promql"
|
|
"github.com/prometheus/prometheus/promql/promqltest"
|
|
"github.com/prometheus/prometheus/rules"
|
|
"github.com/prometheus/prometheus/scrape"
|
|
"github.com/prometheus/prometheus/storage"
|
|
"github.com/prometheus/prometheus/util/annotations"
|
|
)
|
|
|
|
func TestApiStatusCodes(t *testing.T) {
|
|
for name, tc := range map[string]struct {
|
|
err error
|
|
expectedString string
|
|
expectedCode int
|
|
overrideErrorCode OverrideErrorCode
|
|
}{
|
|
"random error": {
|
|
err: errors.New("some random error"),
|
|
expectedString: "some random error",
|
|
expectedCode: http.StatusUnprocessableEntity,
|
|
},
|
|
|
|
"promql.ErrTooManySamples": {
|
|
err: promql.ErrTooManySamples("some error"),
|
|
expectedString: "too many samples",
|
|
expectedCode: http.StatusUnprocessableEntity,
|
|
},
|
|
|
|
"overridden error code for engine error": {
|
|
err: promql.ErrTooManySamples("some error"),
|
|
expectedString: "too many samples",
|
|
overrideErrorCode: func(errNum errorNum, err error) (code int, override bool) {
|
|
if errNum == ErrorExec {
|
|
if strings.Contains(err.Error(), "some error") {
|
|
return 999, true
|
|
}
|
|
return 998, true
|
|
}
|
|
|
|
return 0, false
|
|
},
|
|
expectedCode: 999,
|
|
},
|
|
|
|
"promql.ErrQueryCanceled": {
|
|
err: promql.ErrQueryCanceled("some error"),
|
|
expectedString: "query was canceled",
|
|
expectedCode: statusClientClosedConnection,
|
|
},
|
|
|
|
"promql.ErrQueryTimeout": {
|
|
err: promql.ErrQueryTimeout("some error"),
|
|
expectedString: "query timed out",
|
|
expectedCode: http.StatusServiceUnavailable,
|
|
},
|
|
|
|
"context.DeadlineExceeded": {
|
|
err: context.DeadlineExceeded,
|
|
expectedString: "context deadline exceeded",
|
|
expectedCode: http.StatusUnprocessableEntity,
|
|
},
|
|
|
|
"context.Canceled": {
|
|
err: context.Canceled,
|
|
expectedString: "context canceled",
|
|
expectedCode: statusClientClosedConnection,
|
|
},
|
|
} {
|
|
for k, q := range map[string]storage.SampleAndChunkQueryable{
|
|
"error from queryable": errorTestQueryable{err: tc.err},
|
|
"error from querier": errorTestQueryable{q: errorTestQuerier{err: tc.err}},
|
|
"error from seriesset": errorTestQueryable{q: errorTestQuerier{s: errorTestSeriesSet{err: tc.err}}},
|
|
} {
|
|
t.Run(fmt.Sprintf("%s/%s", name, k), func(t *testing.T) {
|
|
r := createPrometheusAPI(t, q, tc.overrideErrorCode)
|
|
rec := httptest.NewRecorder()
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/query?query=up", nil)
|
|
|
|
r.ServeHTTP(rec, req)
|
|
|
|
require.Equal(t, tc.expectedCode, rec.Code)
|
|
require.Contains(t, rec.Body.String(), tc.expectedString)
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
func createPrometheusAPI(t *testing.T, q storage.SampleAndChunkQueryable, overrideErrorCode OverrideErrorCode) *route.Router {
|
|
t.Helper()
|
|
|
|
engine := promqltest.NewTestEngineWithOpts(t, promql.EngineOpts{
|
|
Logger: promslog.NewNopLogger(),
|
|
Reg: nil,
|
|
ActiveQueryTracker: nil,
|
|
MaxSamples: 100,
|
|
Timeout: 5 * time.Second,
|
|
})
|
|
|
|
api := NewAPI(
|
|
engine,
|
|
q,
|
|
nil,
|
|
nil,
|
|
func(context.Context) ScrapePoolsRetriever { return &DummyScrapePoolsRetriever{} },
|
|
func(context.Context) TargetRetriever { return &DummyTargetRetriever{} },
|
|
func(context.Context) AlertmanagerRetriever { return &DummyAlertmanagerRetriever{} },
|
|
func() config.Config { return config.Config{} },
|
|
map[string]string{}, // TODO: include configuration flags
|
|
GlobalURLOptions{},
|
|
func(f http.HandlerFunc) http.HandlerFunc { return f },
|
|
nil, // Only needed for admin APIs.
|
|
"", // This is for snapshots, which is disabled when admin APIs are disabled. Hence empty.
|
|
false, // Disable admin APIs.
|
|
promslog.NewNopLogger(),
|
|
func(context.Context) RulesRetriever { return &DummyRulesRetriever{} },
|
|
0, 0, 0, // Remote read samples and concurrency limit.
|
|
false, // Not an agent.
|
|
regexp.MustCompile(".*"),
|
|
func() (RuntimeInfo, error) { return RuntimeInfo{}, errors.New("not implemented") },
|
|
&PrometheusVersion{},
|
|
nil,
|
|
nil,
|
|
prometheus.DefaultGatherer,
|
|
nil,
|
|
nil,
|
|
false,
|
|
config.RemoteWriteProtoMsgs{config.RemoteWriteProtoMsgV1, config.RemoteWriteProtoMsgV2},
|
|
false,
|
|
false,
|
|
false,
|
|
false,
|
|
5*time.Minute,
|
|
false,
|
|
overrideErrorCode,
|
|
)
|
|
|
|
promRouter := route.New().WithPrefix("/api/v1")
|
|
api.Register(promRouter)
|
|
|
|
return promRouter
|
|
}
|
|
|
|
type errorTestQueryable struct {
|
|
storage.ExemplarQueryable
|
|
q storage.Querier
|
|
err error
|
|
}
|
|
|
|
func (t errorTestQueryable) ExemplarQuerier(context.Context) (storage.ExemplarQuerier, error) {
|
|
return nil, t.err
|
|
}
|
|
|
|
func (t errorTestQueryable) ChunkQuerier(_, _ int64) (storage.ChunkQuerier, error) {
|
|
return nil, t.err
|
|
}
|
|
|
|
func (t errorTestQueryable) Querier(_, _ int64) (storage.Querier, error) {
|
|
if t.q != nil {
|
|
return t.q, nil
|
|
}
|
|
return nil, t.err
|
|
}
|
|
|
|
type errorTestQuerier struct {
|
|
s storage.SeriesSet
|
|
err error
|
|
}
|
|
|
|
func (t errorTestQuerier) LabelValues(context.Context, string, *storage.LabelHints, ...*labels.Matcher) ([]string, annotations.Annotations, error) {
|
|
return nil, nil, t.err
|
|
}
|
|
|
|
func (t errorTestQuerier) LabelNames(context.Context, *storage.LabelHints, ...*labels.Matcher) ([]string, annotations.Annotations, error) {
|
|
return nil, nil, t.err
|
|
}
|
|
|
|
func (errorTestQuerier) Close() error {
|
|
return nil
|
|
}
|
|
|
|
func (t errorTestQuerier) Select(context.Context, bool, *storage.SelectHints, ...*labels.Matcher) storage.SeriesSet {
|
|
if t.s != nil {
|
|
return t.s
|
|
}
|
|
return storage.ErrSeriesSet(t.err)
|
|
}
|
|
|
|
type errorTestSeriesSet struct {
|
|
err error
|
|
}
|
|
|
|
func (errorTestSeriesSet) Next() bool {
|
|
return false
|
|
}
|
|
|
|
func (errorTestSeriesSet) At() storage.Series {
|
|
return nil
|
|
}
|
|
|
|
func (t errorTestSeriesSet) Err() error {
|
|
return t.err
|
|
}
|
|
|
|
func (errorTestSeriesSet) Warnings() annotations.Annotations {
|
|
return nil
|
|
}
|
|
|
|
// DummyScrapePoolsRetriever implements github.com/prometheus/prometheus/web/api/v1.ScrapePoolsRetriever.
|
|
type DummyScrapePoolsRetriever struct{}
|
|
|
|
func (DummyScrapePoolsRetriever) ScrapePools() []string {
|
|
return []string{}
|
|
}
|
|
|
|
// DummyTargetRetriever implements github.com/prometheus/prometheus/web/api/v1.targetRetriever.
|
|
type DummyTargetRetriever struct{}
|
|
|
|
// TargetsActive implements targetRetriever.
|
|
func (DummyTargetRetriever) TargetsActive() map[string][]*scrape.Target {
|
|
return map[string][]*scrape.Target{}
|
|
}
|
|
|
|
// TargetsDropped implements targetRetriever.
|
|
func (DummyTargetRetriever) TargetsDropped() map[string][]*scrape.Target {
|
|
return map[string][]*scrape.Target{}
|
|
}
|
|
|
|
// TargetsDroppedCounts implements targetRetriever.
|
|
func (DummyTargetRetriever) TargetsDroppedCounts() map[string]int {
|
|
return nil
|
|
}
|
|
|
|
// DummyAlertmanagerRetriever implements AlertmanagerRetriever.
|
|
type DummyAlertmanagerRetriever struct{}
|
|
|
|
// Alertmanagers implements AlertmanagerRetriever.
|
|
func (DummyAlertmanagerRetriever) Alertmanagers() []*url.URL { return nil }
|
|
|
|
// DroppedAlertmanagers implements AlertmanagerRetriever.
|
|
func (DummyAlertmanagerRetriever) DroppedAlertmanagers() []*url.URL { return nil }
|
|
|
|
// DummyRulesRetriever implements RulesRetriever.
|
|
type DummyRulesRetriever struct{}
|
|
|
|
// RuleGroups implements RulesRetriever.
|
|
func (DummyRulesRetriever) RuleGroups() []*rules.Group {
|
|
return nil
|
|
}
|
|
|
|
// AlertingRules implements RulesRetriever.
|
|
func (DummyRulesRetriever) AlertingRules() []*rules.AlertingRule {
|
|
return nil
|
|
}
|