prometheus

mirror of https://github.com/prometheus/prometheus.git synced 2025-12-03 08:31:02 +01:00

History

fix(discovery): aws discovery test fix (#17527 )

* fix: aws discovery test fix

Fixes a problem introduced after the merge of this https://github.com/prometheus/prometheus/pull/17138

PR didn't take into account another merged PR!

```
discovery/aws/aws.go:218:54: too many arguments in call to NewEC2Discovery
    have (*EC2SDConfig, *slog.Logger, *ec2Metrics)
    want (*EC2SDConfig, discovery.DiscovererOptions)
discovery/aws/aws.go:222:66: too many arguments in call to NewLightsailDiscovery
    have (*LightsailSDConfig, *slog.Logger, *lightsailMetrics)
    want (*LightsailSDConfig, discovery.DiscovererOptions)
```

Signed-off-by: Will Bollock <wbollock@linode.com>

* fix: align ecs style

ECS was a new service discovery tool added after this PR was merged: https://github.com/prometheus/prometheus/pull/17138

Aligns the style of passing a single "opts" to it like almost all the other
service discovery engines now use

Signed-off-by: Will Bollock <wbollock@linode.com>

---------

Signed-off-by: Will Bollock <wbollock@linode.com>

2025-11-16 10:28:50 +00:00

aws_test.go

feat: AWS ECS Service Discovery

2025-11-06 22:48:07 +00:00

aws.go

fix(discovery): aws discovery test fix (#17527 )

2025-11-16 10:28:50 +00:00

ec2_test.go

Fix merge formatting

2025-08-07 21:17:21 -04:00

ec2.go

Merge pull request #17138 from wbollock/feat/prometheus_refresh_config_label