Rather than removing the previous implementation of SanitizeLabelName,
offer another version named SanitizeFullLabelName that achieved the
desired requirements, without breaking existing Prometheus code.
Update testing to validate correctness of new variant.
Signed-off-by: Nick Moore <nicholas.moore@grafana.com>
SanitizeLabelName was not correctly sanitizing label names that:
1. Started with a digit (0-9)
2. Were empty
This commit changes the santization code to catch both of these edge
cases and adds new tests to validate it works correctly in them both. In
the first case, a leading digit will be replaced with an underscore, and
in the latter, the function will return a single underscore.
Signed-off-by: Nick Moore <nicholas.moore@grafana.com>
This reverts commit aa43d34a86cf0124a1a8cecc92c544f7f4793d91.
This brings back the /graph changes so that @grandbora can continue to
work on the redirect for backwards compatibility. And other changes
can already take the new /graph parameters into account.
This revert will be reverted once v1.1 is released and has its own
release branch. Since we had already change on top of this, there was
no cleaner way of cutting those changes out.
This commit reverts the following commits:
Revert "Update backend helpers and templates to new url schema"
This reverts commit fc6cdd0611f5eae523c4eb54b74b97a18c174972.
Revert "Refactor graph.js"
This reverts commit 445fac56e07b29bf31b55f34493273ee1c84f9d6.
Revert "Use query parameters in the url"
This reverts commit 3e18d86d8a424e32dfb7584fe4fa751d3126f3f3.
Revert "Point to correct place for GraphLinkForExpression"
This reverts commit 3da825fc76252155aade2bb25203428579df42e8.
Assets are also updated.
It's actually happening in several places (and for flags, we use the
standard Go time.Duration...). This at least reduces all our
home-grown parsing to one place (in model).
