mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-05-15 01:27:01 +02:00
Code Issues Projects Releases Wiki Activity
14,028 Commits 361 Branches 529 Tags
Commit Graph

426 Commits

Author SHA1 Message Date
bwplotka
5061ae7ec4 manager: Fixed CT OMText conversion bug; Refactored tests. 
Signed-off-by: bwplotka <bwplotka@gmail.com>
 2024-10-01 14:00:32 +01:00
Manik Rana
030c684a54 Merge branch 'main' into implement-ct-in-append 2024-09-22 09:35:21 +05:30
Bryan Boreham
31c5760551
Neater string vs byte-slice conversions (#14425) 
unsafe.Slice and unsafe.StringData were added in Go 1.20

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-09-21 12:19:21 +02:00
Arthur Silva Sens
ca18f298e1
Merge pull request #14949 from Maniktherana/minor-fixes-ct 
refac: make typeRequiresCT private
 2024-09-20 17:41:06 +01:00
Manik Rana
315165e49d refac: make typeRequiresCT private 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-09-20 21:56:19 +05:30
Manik Rana
28afd0dc50
Merge branch 'main' into implement-ct-in-append 
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
 2024-09-20 21:16:01 +05:30
Björn Rabenstein
5b9148e552
Merge pull request #14820 from charleskorn/promqltest-native-histogram-format 
promqltest: use test expression format for histograms in assertion failure messages and include reset hint in the test expression
 2024-09-20 16:47:08 +02:00
Charles Korn
6dbb4e1a94
Fix linting issues 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-09-20 11:49:54 +10:00
Mario Fernandez
5814920601
Fix: optimize .* regexp performance 
Shortcut for `.*` matches newlines as well.
Add preamble change ^(?s:
Add test
dotAll flag por al regex
Add and fix regex tests

Signed-off-by: Mario Fernandez <mariofer@redhat.com>
 2024-09-17 12:18:31 +02:00
Nathan Baulch
50cd453c8f
chore: Fix typos (#14868) 
* Fix typos

---------

Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
 2024-09-10 22:32:03 +02:00
Charles Korn
e8c7482137
Return negative counts when multiplied or divided by a negative value 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-09-09 14:37:59 +10:00
Charles Korn
e67358d203
histogram: include counter reset hint in test expression output 
Signed-off-by: Charles Korn <charles.korn@grafana.com>
 2024-09-04 15:46:52 +10:00
Björn Rabenstein
4ffb74dae4
Merge pull request #14810 from bboreham/fix-proto-parse-exemplar 
[BUGFIX] Protobuf scraping: reset exemplar position
 2024-09-03 15:05:59 +02:00
Bryan Boreham
d599c4b28c [BUGFIX] Protobuf scraping: reset exemplar position 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-09-02 16:43:50 +01:00
Bryan Boreham
3aaf2c3c9d [TESTS] Add second native histogram with exemplars in TestProtobufParse 
This test fails.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-09-02 16:43:50 +01:00
Bryan Boreham
e8ecc11816 [TESTS] Fix up item numbers in TestProtobufParse 
If an error is thrown by the test, these numbers help you see which item is wrong.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-09-02 16:43:49 +01:00
Manik Rana
9536ff4ecb fix: finish refac 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-09-02 17:57:10 +05:30
Manik Rana
8c070dcc41
refac: rename skipOMSeries to skipOMCTSeries 
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
 2024-09-02 17:52:36 +05:30
Manik Rana
18f95cc994 Merge branch 'main' into implement-ct-in-append 2024-08-30 13:46:03 +05:30
Owen Williams
9da75328ea
fix(utf8): ensure correct validation when legacy mode turned on (#14736) 
fix(utf8): ensure correct validation when legacy mode turned on

This depends on the included update of the prometheus/common dependency.

---------

Signed-off-by: Owen Williams <owen.williams@grafana.com>
 2024-08-28 17:15:42 +02:00
riskrole
406bf775aa chore: fix some comments 
Signed-off-by: riskrole <yuhang@before.tech>
 2024-08-28 11:26:57 +08:00
Manik Rana
bec708eda8 chore: gofumpt 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-08-27 21:59:22 +05:30
Manik Rana
fd2a2b1b9e fix: set skipOMSeries in test 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-08-27 21:10:51 +05:30
Manik Rana
3de6bffae7 chore: lint 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-08-27 21:04:07 +05:30
Manik Rana
d14eb733e8 refac: allow opt-in to OM CT ingestion 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-08-27 21:01:21 +05:30
Manik Rana
82064d42b8 feat: init NewOpenMetricsParser with skipCT true 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-08-27 02:32:25 +05:30
Manik Rana
c4052ba23d chore: revert TypeRequiresCT to private 
Signed-off-by: Manik Rana <manikrana54@gmail.com>
 2024-08-27 02:31:47 +05:30
beorn7
0f760f63dd lint: Revamp our linting rules, mostly around doc comments 
Several things done here:

- Set `max-issues-per-linter` to 0 so that we actually see all linter
  warnings and not just 50 per linter. (As we also set
  `max-same-issues` to 0, I assume this was the intention from the
  beginning.)

- Stop using the golangci-lint default excludes (by setting
  `exclude-use-default: false`. Those are too generous and don't match
  our style conventions. (I have re-added some of the excludes
  explicitly in this commit. See below.)

- Re-add the `errcheck` exclusion we have used so far via the
  defaults.

- Exclude the signature requirement `govet` has for `Seek` methods
  because we use non-standard `Seek` methods a lot. (But we keep other
  requirements, while the default excludes completely disabled the
  check for common method segnatures.)

- Exclude warnings about missing doc comments on exported symbols. (We
  used to be pretty adamant about doc comments, but stopped that at
  some point in the past. By now, we have about 500 missing doc
  comments. We may consider reintroducing this check, but that's
  outside of the scope of this commit. The default excludes of
  golangci-lint essentially ignore doc comments completely.)

- By stop using the default excludes, we now get warnings back on
  malformed doc comments. That's the most impactful change in this
  commit. It does not enforce doc comments (again), but _if_ there is
  a doc comment, it has to have the recommended form. (Most of the
  changes in this commit are fixing this form.)

- Improve wording/spelling of some comments in .golangci.yml, and
  remove an outdated comment.

- Leave `package-comments` inactive, but add a TODO asking if we
  should change that.

- Add a new sub-linter `comment-spacings` (and fix corresponding
  comments), which avoids missing spaces after the leading `//`.

Signed-off-by: beorn7 <beorn@grafana.com>
 2024-08-22 17:36:11 +02:00
Manik Rana
02c465bf58
textparse: Implement CreatedTimestamp() in openmetricsparse.go (#14356) 
* feat: initial implement of createedTimestamp() with tests

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: return ct after finding it

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: remove unneeded test

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: add comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: multiple changes

- implement changes from pair programming session
- use newParse.val()
- advance parser p if ct is found

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: check if err from p.Next()

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: advance parser and parse histograms + summary

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: restore previous tests

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: retore failing tests

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: remove unneeded comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: return nil when mtype doesn't match

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: update go fmt version

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: cleanup

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: document deepcopyparser

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: cover edgecase of `gauge_created` in CreatedTimestamp()

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: readability updates

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: dedeuplicate labeldiff checks

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* tests: add tests for new label functions

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* feat: document CreatedTimestamp func

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: optimize `CreatedTimestamp()`

 - Use refactored CreatedTimestamp function with bug fixes
 - Remove unused code in labels.go
 - Improve code documentation

 Signed-off-by: Manik Rana <manikrana54@gmail.com>

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: add tests and lint fixes

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: remove mName

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* tests: add tests for CT parse failures and deepCopy

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: edit expectCT struct

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: add new label in deepCopy

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: use p.builder in deepCopy

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: add NewMetricsParserWithOpts

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* chore: comments

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* chore: rename var

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: add condition for OM fuzzing

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: build tags

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: default skipCT to false

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: rename skipCT to skipCTSeries

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: formatting

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments and readability updates

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* refac: remove NewOpenMetricsParserWithOpts

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: extract skipCTSeries logic from parseMetricSuffix

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* refac: inline create a NewOpenMetricsParser

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: comments

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>

* refac: improve error handling

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: return error instead of nil

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* fix: remove skipCT check from tBraceOpen

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* Pair programming with Manik, Arthur and Daniel.

Signed-off-by: bwplotka <bwplotka@gmail.com>

* chore: comments and use helper funcs

Signed-off-by: Manik Rana <manikrana54@gmail.com>

* chore: lint

Signed-off-by: Manik Rana <manikrana54@gmail.com>

---------

Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
 2024-08-08 12:35:35 +01:00
Marco Pracucci
d4f098ae80
Fix relabel.Regexp zero value marshalling (#14517) 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
 2024-07-26 12:55:39 +00:00
Bryan Boreham
d84282b105 Labels: use single byte as separator - small speedup 
Since `seps` is a variable, `seps[0]` has to be bounds-checked every
time. Replacing with a constant everywhere it is used skips this
overhead.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-07-15 09:47:16 +01:00
Bryan Boreham
82a8c6abe2
[ENHANCEMENT] Optimize regexps with multiple prefixes (#13843) 
For example `foo.*|bar.*|baz.*`. Instead of checking each one in turn,
we build a map of prefixes, then check the smaller set that could match
the string supplied.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

* Improve testing and readability

Address review comments on #13843

Signed-off-by: Marco Pracucci <marco@pracucci.com>
 2024-07-03 18:45:36 +01:00
Marco Pracucci
ec31acaf02
FastRegexMatcher: small optimization for the literal prefix case 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
 2024-07-01 10:12:50 +02:00
Bryan Boreham
675d02cd0b
Merge pull request #14333 from bboreham/faster-dedupelabels 
[PERF] Labels: faster encoding for -tags dedupelabels
 2024-06-30 12:26:48 +01:00
Björn Rabenstein
2e58d46522
Merge pull request #13662 from prometheus/nhcb 
Native histograms custom buckets storage
 2024-06-27 21:44:20 +02:00
Björn Rabenstein
cb7306155b
Merge pull request #14004 from liam-howe-maersk/implement-config-marshal 
configuration: Implement IsZero for relabel.Regex to remove default regex
 2024-06-27 12:13:14 +02:00
György Krajcsovits
505ffd34ef Fix lint error 
Some weird formatting issue in using comment suggestion

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
 2024-06-24 09:33:03 +02:00
George Krajcsovits
f45709e710
Update model/histogram/histogram_test.go 
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
 2024-06-24 07:51:56 +02:00
Bryan Boreham
7a82e4b503 Labels benchmarks: remove artefact of small symbol-tables 
Symbol tables with fewer than 128 entries, so everything can be
represented as a single byte, are not realistic.

Stuff the symbol table with fake entries before adding the real ones.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-06-21 16:49:10 +01:00
Bryan Boreham
2ba7bc9446 Labels: further optimisation for dedupelabels 
Inline (by copy-paste) the fast path of `decodeVarint` in various
places where it gets called a lot.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-06-21 16:46:13 +01:00
Bryan Boreham
2ced2f6aec [PERF] Labels: faster varint for dedupelabels 
Including tests.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-06-21 11:57:09 +01:00
Jeanette Tan
dda5f48c9e Merge branch 'main' into nhcb-review-2 2024-06-20 22:50:00 +08:00
Bryan Boreham
84602bbace
Merge branch 'main' into fix-matcher-string-with-empty-label-name 2024-06-19 05:56:25 -04:00
Oleg Zaytsev
4f78cc809c
Refactor toNormalisedLower: shorter and slightly faster. (#14299) 
Refactor toNormalisedLower: shorter and slightly faster

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-06-18 09:57:37 +00:00
Oleg Zaytsev
03cf6141d4
Fix Matcher.String() with empty label name 
When the label name is empty, which can happen now with quoted label
name, it should be quoted when printed as a string again.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
 2024-06-13 18:46:35 +02:00
Ranveer Avhad
39902ba694
[BUGFIX] FastRegexpMatcher: do Unicode normalization as part of case-insensitive comparison (#14170) 
* Converted string to standarized form
* Added golang.org/x/text in Go dependencies
* Added test cases for FastRegexMatcher
* Added benchmark for toNormalizedLower

Signed-off-by: RA <ranveeravhad777@gmail.com>
 2024-06-10 18:31:41 -04:00
Jeanette Tan
5e4e93c316 fix lint 
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
 2024-06-07 19:24:05 +08:00
Jeanette Tan
14f8dded39 Merge branch 'main' into nhcb 
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
 2024-06-07 19:17:14 +08:00
Jeanette Tan
9adc1699c3 fix according to code review 
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
 2024-06-07 18:50:59 +08:00
Bryan Boreham
6fb738af51
Merge pull request #14173 from pracucci/fastregexmatcher-optimize-contains 
Improve contains check done by FastRegexMatcher
 2024-06-06 19:59:23 +03:00