mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-02-10 18:31:12 +01:00
Code Issues Projects Releases Wiki Activity
16,879 Commits 335 Branches 510 Tags
Commit Graph

91 Commits

Author SHA1 Message Date
Ben Kochie
e14795bbf4
Remove copyright date from headers (#17785) 
Remove copyright dates from various files as part of [PROM-50].

[PROM-50]: https://github.com/prometheus/proposals/blob/main/proposals/0050-remove-copyright-dates.md

Signed-off-by: SuperQ <superq@gmail.com>
 2026-01-05 13:46:21 +01:00
Arve Knudsen
913cc8f72b
Replace gopkg.in/yaml.v2 with go.yaml.in/yaml/v2 (#17151) 
* Replace gopkg.in/yaml.v2 with go.yaml.in/yaml/v2
* Upgrade to client_golang@v1.23.2

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2025-09-06 13:04:24 +02:00
beorn7
747c5ee2b1 Apply analyzer "modernize" to the whole codebase 
See
https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize
for details.

This ran into a few issues (arguably bugs in the modernize tool),
which I will fix in the next commit, so that we have transparency what
was done automatically.

Beyond those hiccups, I believe all the changes applied are
legitimate. Even where there might be no tangible direct gain, I would
argue it's still better to use the "modern" way to avoid micro
discussions in tiny style PRs later.

Signed-off-by: beorn7 <beorn@grafana.com>
 2025-08-27 14:48:41 +02:00
Arve Knudsen
e7e3ab2824
Fix linting issues found by golangci-lint v2.0.2 (#16368) 
* Fix linting issues found by golangci-lint v2.0.2

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
 2025-05-03 19:05:13 +02:00
Matthieu MOREL
c7d4b53ec1 chore: enable unused-parameter from revive 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-02-19 19:50:28 +01:00
crystalstall
616914abe2 Signed-off-by: crystalstall <crystalruby@qq.com> 
refactor: using slices.Contains to simplify the code

Signed-off-by: crystalstall <crystalruby@qq.com>
 2025-01-11 00:41:51 +08:00
hongmengning
2a1b940ae4 discovery: fix some function names in comment 
Signed-off-by: hongmengning <go@before.tech>
 2024-11-25 17:33:04 +08:00
Matthieu MOREL
af1a19fc78 enable errorf rule from perfsprint linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-11-06 16:50:36 +01:00
Bryan Boreham
b87b88ddc2
Merge branch 'main' into consul-catalog-filter-support 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-10-08 12:20:31 +01:00
TJ Hoplock
6ebfbd2d54 chore!: adopt log/slog, remove go-kit/log 
For: #14355

This commit updates Prometheus to adopt stdlib's log/slog package in
favor of go-kit/log. As part of converting to use slog, several other
related changes are required to get prometheus working, including:
- removed unused logging util func `RateLimit()`
- forward ported the util/logging/Deduper logging by implementing a small custom slog.Handler that does the deduping before chaining log calls to the underlying real slog.Logger
- move some of the json file logging functionality to use prom/common package functionality
- refactored some of the new json file logging for scraping
- changes to promql.QueryLogger interface to swap out logging methods for relevant slog sugar wrappers
- updated lots of tests that used/replicated custom logging functionality, attempting to keep the logical goal of the tests consistent after the transition
- added a healthy amount of `if logger == nil { $makeLogger }` type conditional checks amongst various functions where none were provided -- old code that used the go-kit/log.Logger interface had several places where there were nil references when trying to use functions like `With()` to add keyvals on the new *slog.Logger type

Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
 2024-10-07 15:58:50 -04:00
Matthieu MOREL
ab64966e9d
fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094) 
* fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()"

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
 2024-10-06 16:35:29 +00:00
Oleksandr Redko
f10c3454e9 Enable perfsprint linter and fix up code 
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
 2024-05-15 17:51:05 +03:00
Daniel Kimsey
aa3e58358b consul: Add support for catalog list services filter 
This adds support for Consul's Catalog [List Services][^1] API's `filter`
parameter added in 1.14.x. This parameter grants the operator more
flexibility to do server-side filtering of the Catalog, before
Prometheus subscribes for updates. Operators can use this to improve
both the performance of Prometheus's Consul SD and reduce the impact of
enumerating large catalogs.

[^1]: https://developer.hashicorp.com/consul/api-docs/v1.14.x/catalog

Signed-off-by: Daniel Kimsey <dekimsey@protonmail.com>
 2024-03-17 20:32:54 -05:00
Bryan Boreham
b17f88b7fb consul sd tests: don't call FailNow from a background goroutine 
This is not allowed by the Go test framework.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-01 15:15:48 +00:00
Bryan Boreham
46008fdecd lint 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
 2024-02-01 14:57:11 +00:00
Paweł Szulik
7f24efccdb Refactor discovery tests to use testify. 
Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>
 2024-01-31 16:42:11 +00:00
Paulin Todev
78411d5e8b
SD Managers taking over responsibility for registration of debug metrics (#13375) 
SD Managers take over responsibility for SD metrics registration

---------

Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
Signed-off-by: Björn Rabenstein <github@rabenste.in>
Co-authored-by: Björn Rabenstein <github@rabenste.in>
 2024-01-23 16:53:55 +01:00
Paulin Todev
6de80d7fb0
Allow non-default registry to be used for metrics of SD components 
Signed-off-by: Paulin Todev <paulin.todev@gmail.com>
 2023-12-11 11:14:26 +00:00
Matthieu MOREL
9c4782f1cc
golangci-lint: enable testifylint linter (#13254) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2023-12-07 11:35:01 +00:00
Oleksandr Redko
fa90ca46e5 ci(lint): enable godot; append dot at the end of comments 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2023-10-31 19:53:38 +02:00
Julien Pivotto
0dc31ade41 Add support for consul path_prefix 
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
 2023-05-17 00:14:58 +02:00
Fish-pro
43d77f7c41 Use http constants instead of string 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
 2023-02-10 10:21:05 +08:00
David Cañadillas
51a44e6657
Adding Consul Enterprise Admin Partitions (#11482) 
* Adding Consul Enterprise Admin Partitions

Signed-off-by: dcanadillas <dcanadillas@hashicorp.com>
 2022-10-21 14:13:01 +02:00
Matthieu MOREL
f43749e82f
refactor (discovery): move from github.com/pkg/errors to 'errors' and 'fmt' (#10807) 
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>

Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
 2022-06-03 13:47:14 +02:00
Julien Pivotto
98039cddfa
Update Prometheus common (#10492) 
* Update Prometheus common

- Oauth2 supports proxy URL
- HTTP2 can be disabled

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2022-03-30 12:49:03 +02:00
Mateusz Gozdek
0bfef847b0 discovery/consul: fix leaking goroutine from test 
Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
 2021-11-10 09:40:43 +01:00
Conor Evans
c28b9a0574
Add datacenter to Consul service discovery logs (#9668) 
* add datacenter to consul service discovery logs

Signed-off-by: Conor Evans <coevans@tcd.ie>
 2021-11-08 09:34:21 +01:00
Mateusz Gozdek
1a6c2283a3 Format Go source files using 'gofumpt -w -s -extra' 
Part of #9557

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
 2021-11-02 19:52:34 +01:00
Julien Pivotto
63b3e4e5ec
Enable HTTP2 again (#9398) 
We are re-enabling HTTP 2 again. There has been a few bugfixes upstream
in go, and we have also enabled ReadIdleTimeout.

Fix #7588
Fix #9068

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2021-09-26 23:16:12 +02:00
jinglina
ed24e51e7c
remove redundant type conversion (#9126) 
Signed-off-by: jinglina <jinglinax@163.com>
 2021-07-28 13:33:46 +05:30
Levi Harrison
faed8df31d
Enable reading consul token from file (#8926) 
* Adopted common http client

Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-06-12 00:06:59 +02:00
Levi Harrison
b5f6f8fb36 Switched to go-kit/log 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
 2021-06-11 12:28:36 -04:00
Austin Cawley-Edwards
301815e48b
Update prometheus-common and the consul HTTP client (#8913) 
* Update to prometheus-common@v0.29.0

Signed-off-by: austin ce <austin.cawley@gmail.com>
 2021-06-11 14:24:41 +02:00
Frederic Hemberger
39a87fd9d2 consul_sd: Add namespace support for Consul Enterprise 
Signed-off-by: Frederic Hemberger <mail@frederic-hemberger.de>
 2021-06-09 16:35:02 +02:00
songjiayang
b781b5cac5
Refactor file discovery init function (#8891) 
* Refactor file discovery init function

Combine to one init function like other discovery.

Signed-off-by: songjiayang <songjiayang1@gmail.com>
 2021-06-04 14:43:24 +02:00
Nick Triller
fddf4918c0
Send empty targetgroup if nothing discovered 
Signed-off-by: Nick Triller <nicktriller@gmail.com>
 2021-04-29 09:06:52 +02:00
Julien Pivotto
6c56a1faaa
Testify: move to require (#8122) 
* Testify: move to require

Moving testify to require to fail tests early in case of errors.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* More moves

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-10-29 09:43:23 +00:00
Julien Pivotto
1282d1b39c
Refactor test assertions (#8110) 
* Refactor test assertions

This pull request gets rid of assert.True where possible to use
fine-grained assertions.

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-10-27 11:06:53 +01:00
Julien Pivotto
4e5b1722b3
Move away from testutil, refactor imports (#8087) 
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-10-22 11:00:08 +02:00
johncming
a5beb627ff
some fixies for consul sd. (#7799) 
* discovery/consul: make duration more accurate.

Signed-off-by: johncming <johncming@yahoo.com>

* discovery/consul: fix bug when context done.

Signed-off-by: johncming <johncming@yahoo.com>
 2020-08-25 15:46:14 +02:00
Andy Bursavich
4e6a94a27d
Invert service discovery dependencies (#7701) 
This also fixes a bug in query_log_file, which now is relative to the config file like all other paths.

Signed-off-by: Andy Bursavich <abursavich@gmail.com>
 2020-08-20 13:48:26 +01:00
Julien Pivotto
9da53391d1
Merge pull request #7739 from prometheus/release-2.20 
Merge release-2.20 into the main branch after Consul fix
 2020-08-04 20:15:43 +02:00
Julien Pivotto
3a7120bc07 Consul: Reduce WatchTimeout to 2m and set it as timeout for requests 
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-08-03 00:42:55 +02:00
Julien Pivotto
93e9c010f3
Add more Go leak tests (#7652) 
* Implement go leak test for promql

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* Implement go leak test for Consul SD

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

* Implement go leak test in discovery manager

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
 2020-07-24 10:10:20 +01:00
John Bampton
98a69b77d1
Fix spelling (#7512) 
Signed-off-by: John Bampton <jbampton@users.noreply.github.com>
 2020-07-04 14:54:26 +02:00
Pierre Souchay
1508678001
Use 10m timeouts for watches (#7423) 
use ?wait=10m will give results as fast as usual when data is changing
but will perform far less requests when services do not change.

On large infrastructure, this will reduce quite a lot the number of
qps on Consul servers while having the same performance for freshness
of results.

Signed-off-by: Pierre Souchay <p.souchay@criteo.com>
 2020-06-20 20:22:45 +01:00
Mathilde Gilles
9b9c58aea8
[Consul] Add health label to metrics (#5313) 
Label metrics with the target health using consul's /health endpoint.

Signed-off-by: Mathilde Gilles <m.gilles@criteo.com>
 2020-02-25 13:32:30 +00:00
Simon Pasquier
fe76ccbfe3
discovery/consul: fix logging of tags (#6783) 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
 2020-02-13 13:11:44 +01:00
Ben Ye
60527de355
keep consul service metrics in global variables (#6764) 
Signed-off-by: yeya24 <yb532204897@gmail.com>
 2020-02-06 05:48:58 +00:00
Josh Soref
91d76c8023 Spelling (#6517) 
* spelling: alertmanager

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: attributes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: autocomplete

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: bootstrap

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: caught

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: chunkenc

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: compaction

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: corrupted

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deletable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: expected

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fine-grained

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: initialized

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: iteration

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: javascript

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multiple

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: number

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: overlapping

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: possible

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: postings

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: procedure

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: programmatic

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: queuing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: querier

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repairing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: received

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: reproducible

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: retention

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sample

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: segements

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: semantic

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: software [LICENSE]

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: staging

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: timestamp

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unfortunately

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: uvarint

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: subsequently

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: ressamples

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
 2020-01-02 15:54:09 +01:00