From ff49406cbab6c3155d8bf4b19aa7b8d5b1017d38 Mon Sep 17 00:00:00 2001 From: beorn7 Date: Tue, 14 Oct 2025 00:52:23 +0200 Subject: [PATCH] promql: Expose bug of not checking 1st histogram for CRH avg_over_time already correctly checked the counter reset hint fo all histograms, but in sum_over_time, the 1st histogram was missed in the loop. This commit exposes the bug in a test. Signed-off-by: beorn7 --- promql/promqltest/testdata/native_histograms.test | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/promql/promqltest/testdata/native_histograms.test b/promql/promqltest/testdata/native_histograms.test index 9ec222c17c..986b8de04f 100644 --- a/promql/promqltest/testdata/native_histograms.test +++ b/promql/promqltest/testdata/native_histograms.test @@ -1709,6 +1709,18 @@ eval instant at 14m histogram_count(avg_over_time(mixed[10m])) expect no_info {} 9.3 +# In the following two tests, the first sample has hint "not_reset" +# and the second has "reset". This tests if the conflict is detected +# between the first two samples, too. +eval instant at 11m histogram_count(sum_over_time(mixed[2m])) + expect warn msg:PromQL warning: conflicting counter resets during histogram aggregation + expect no_info + {} 21 + +eval instant at 11m histogram_count(avg_over_time(mixed[2m])) + expect warn msg:PromQL warning: conflicting counter resets during histogram aggregation + expect no_info + {} 10.5 # Test histogram_quantile annotations. load 1m