From 91ef9a50b98e39225580ad49523524919e0a983f Mon Sep 17 00:00:00 2001 From: machine424 Date: Tue, 2 Sep 2025 12:26:03 +0200 Subject: [PATCH] chore(prombench): re-roder checks on nodes to avoid deadlocks start and cancel and in restart the start job requires the node pools to be gone before creating them, and the cleanup and restart jobs require the pools to be running to delete them, When the initial start is partial (only one pool was created), no command can move forward... the preconditions should be relaxed, for more robustness. Signed-off-by: machine424 --- .github/workflows/prombench.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/prombench.yml b/.github/workflows/prombench.yml index 65d1d71917..5eb9becc0a 100644 --- a/.github/workflows/prombench.yml +++ b/.github/workflows/prombench.yml @@ -38,8 +38,8 @@ jobs: uses: docker://prominfra/prombench:master with: args: >- - until make all_nodes_deleted; do echo "waiting for nodepools to be deleted"; sleep 10; done; make deploy; + until make all_nodes_running; do echo "waiting for nodepools to be created"; sleep 10; done; - name: Update status to failure if: failure() run: >- @@ -73,8 +73,8 @@ jobs: uses: docker://prominfra/prombench:master with: args: >- - until make all_nodes_running; do echo "waiting for nodepools to be created"; sleep 10; done; make clean; + until make all_nodes_deleted; do echo "waiting for nodepools to be deleted"; sleep 10; done; - name: Update status to failure if: failure() run: >- @@ -108,10 +108,10 @@ jobs: uses: docker://prominfra/prombench:master with: args: >- - until make all_nodes_running; do echo "waiting for nodepools to be created"; sleep 10; done; make clean; until make all_nodes_deleted; do echo "waiting for nodepools to be deleted"; sleep 10; done; make deploy; + until make all_nodes_running; do echo "waiting for nodepools to be created"; sleep 10; done; - name: Update status to failure if: failure() run: >-