From ef01f33a03389d155ebabf51e9fcc7c30977cc2f Mon Sep 17 00:00:00 2001 From: Bartlomiej Plotka Date: Fri, 8 May 2026 10:17:57 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka --- prompb/io/prometheus/write/v2/codec.go | 2 +- storage/remote/write_handler.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/prompb/io/prometheus/write/v2/codec.go b/prompb/io/prometheus/write/v2/codec.go index ebdd900c71..034ac84da3 100644 --- a/prompb/io/prometheus/write/v2/codec.go +++ b/prompb/io/prometheus/write/v2/codec.go @@ -31,7 +31,7 @@ func (m TimeSeries) ToLabels(b *labels.ScratchBuilder, symbols []string) (labels return desymbolizeLabels(b, m.GetLabelsRefs(), symbols) } -// ToMetadata return model metadata from timeseries' remote metadata. +// ToMetadata returns model metadata from timeseries' remote metadata. func (m TimeSeries) ToMetadata(symbols []string) (metadata.Metadata, error) { typ := model.MetricTypeUnknown switch m.Metadata.Type { diff --git a/storage/remote/write_handler.go b/storage/remote/write_handler.go index 282669ea3c..e963879212 100644 --- a/storage/remote/write_handler.go +++ b/storage/remote/write_handler.go @@ -322,7 +322,6 @@ func (h *writeHandler) appendV2(app storage.Appender, req *writev2.Request, rs * m, err := ts.ToMetadata(req.Symbols) if err != nil { badRequestErrs = append(badRequestErrs, fmt.Errorf("parsing metadata for series %v: %w", ts.LabelsRefs, err)) - samplesWithInvalidLabels += len(ts.Samples) + len(ts.Histograms) continue } if h.enableTypeAndUnitLabels && (m.Type != model.MetricTypeUnknown || m.Unit != "") {