mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-05 21:57:09 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #16895 from bboreham/noinline-kahan

Browse Source 
[BUGFIX] PromQL: Noinline kahanSumInc, to reduce numerical errors
This commit is contained in:
Bryan Boreham 2025-07-28 15:55:19 +01:00 committed by GitHub
commit e9cf792c47
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
promql/functions.go
View File

@ -1188,6 +1188,9 @@ func funcTimestamp(vectorVals []Vector, _ Matrix, _ parser.Expressions, enh *Eva
return enh.Out, nil return enh.Out, nil
} }
// We get incorrect results if this function is inlined; see https://github.com/prometheus/prometheus/issues/16714.
//
//go:noinline
func kahanSumInc(inc, sum, c float64) (newSum, newC float64) { func kahanSumInc(inc, sum, c float64) (newSum, newC float64) {
t := sum + inc t := sum + inc
switch { switch {