From e57512acfc18e621bb3be5b14972fcf98168ac9a Mon Sep 17 00:00:00 2001 From: Julien Pivotto <291750+roidelapluie@users.noreply.github.com> Date: Mon, 7 Apr 2025 12:58:34 +0200 Subject: [PATCH] Address feedback Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com> --- promql/durations_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/promql/durations_test.go b/promql/durations_test.go index e86a03db1a..0cdfb7597a 100644 --- a/promql/durations_test.go +++ b/promql/durations_test.go @@ -104,7 +104,7 @@ func TestCalculateDuration(t *testing.T) { expr parser.Expr expected time.Duration errorMessage string - requirePositive bool + allowedNegative bool }{ { name: "addition", @@ -193,7 +193,7 @@ func TestCalculateDuration(t *testing.T) { Op: parser.SUB, }, expected: -5 * time.Second, - requirePositive: true, + allowedNegative: true, }, { name: "division by zero", @@ -225,7 +225,7 @@ func TestCalculateDuration(t *testing.T) { for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { - result, err := calculateDuration(tt.expr, tt.requirePositive) + result, err := calculateDuration(tt.expr, tt.allowedNegative) if tt.errorMessage != "" { require.Error(t, err) require.Contains(t, err.Error(), tt.errorMessage)