From e13bce84489c25de633ccc6987e169670eeca06a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Krajcsovits?= Date: Mon, 4 Aug 2025 17:03:31 +0200 Subject: [PATCH] add TODOs to wrong end positions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: György Krajcsovits --- promql/engine_test.go | 2 +- promql/parser/parse_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/promql/engine_test.go b/promql/engine_test.go index 2f087bfcdf..111ffc3a4b 100644 --- a/promql/engine_test.go +++ b/promql/engine_test.go @@ -2896,7 +2896,7 @@ func TestPreprocessAndWrapWithStepInvariantExpr(t *testing.T) { }, PosRange: posrange.PositionRange{ Start: 29, - End: 51, + End: 52, // TODO(krajorama): this should be 51. https://github.com/prometheus/prometheus/issues/16053 }, }, }, diff --git a/promql/parser/parse_test.go b/promql/parser/parse_test.go index 989e4b8c47..129701b010 100644 --- a/promql/parser/parse_test.go +++ b/promql/parser/parse_test.go @@ -4776,7 +4776,7 @@ var testExpr = []struct { End: 8, }, }, - PosRange: posrange.PositionRange{Start: 1, End: 10}, // TODO(krajorama): this should be 9. + PosRange: posrange.PositionRange{Start: 1, End: 10}, // TODO(krajorama): this should be 9. https://github.com/prometheus/prometheus/issues/16053 }, PosRange: posrange.PositionRange{Start: 0, End: 10}, },